From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Paul Cercueil <paul@crapouillou.net>
Cc: od@zcrc.me, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: Fix doc of clk_get_parent
Date: Sun, 7 Mar 2021 14:30:13 +0000 [thread overview]
Message-ID: <20210307143013.GE1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <J8SLPQ.MXUB9SDIPWN13@crapouillou.net>
On Sun, Mar 07, 2021 at 02:29:07PM +0000, Paul Cercueil wrote:
> Hi,
>
> Le dim. 7 mars 2021 à 14:27, Russell King - ARM Linux admin
> <linux@armlinux.org.uk> a écrit :
> > On Sun, Mar 07, 2021 at 02:06:26PM +0000, Paul Cercueil wrote:
> > > On error, or when the passed parameter is NULL, the return value is
> > > NULL
> > > and not a PTR_ERR()-encoded value.
> >
> > No, the documentation is accurate. The CCF is just an implementation
> > of the API, the file you are modifying is the definitive API
> > documentation.
>
> Well, then the code has to be fixed, because right now it returns NULL on
> error, since the 2.6 days.
And you consider NULL to be an error? A NULL clock isn't defined to be
an error by the API.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-03-07 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 14:06 [PATCH] clk: Fix doc of clk_get_parent Paul Cercueil
2021-03-07 14:27 ` Russell King - ARM Linux admin
2021-03-07 14:29 ` Paul Cercueil
2021-03-07 14:30 ` Russell King - ARM Linux admin [this message]
2021-03-07 15:58 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210307143013.GE1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox