Re: [PATCH v6 2/5] USB: misc: Add onboard_usb_hub driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3454 bytes --]

Hi Matthias,

I love your patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on robh/for-next char-misc/char-misc-testing driver-core/driver-core-testing linus/master v5.12-rc2 next-20210305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210307-113654
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/63d87372b7498dc22220963eb5cd672e929b9514
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210307-113654
        git checkout 63d87372b7498dc22220963eb5cd672e929b9514
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/dev_printk.h:14,
                    from include/linux/device.h:15,
                    from drivers/usb/misc/onboard_usb_hub.c:8:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   drivers/usb/misc/onboard_usb_hub.c: At top level:
>> drivers/usb/misc/onboard_usb_hub.c:273:6: error: redefinition of 'of_is_onboard_usb_hub'
     273 | bool of_is_onboard_usb_hub(const struct device_node *np)
         |      ^~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/usb/misc/onboard_usb_hub.c:21:
   include/linux/usb/onboard_hub.h:9:20: note: previous definition of 'of_is_onboard_usb_hub' was here
       9 | static inline bool of_is_onboard_usb_hub(const struct device_node *np)
         |                    ^~~~~~~~~~~~~~~~~~~~~


vim +/of_is_onboard_usb_hub +273 drivers/usb/misc/onboard_usb_hub.c

   272	
 > 273	bool of_is_onboard_usb_hub(const struct device_node *np)
   274	{
   275		return !!of_match_node(onboard_hub_match, np);
   276	}
   277	EXPORT_SYMBOL_GPL(of_is_onboard_usb_hub);
   278	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 59788 bytes --]