Re: [PATCH v3 4/4] clk: rockchip: add clock controller for rk3568

Stephen Boyd
2021-03-13T22:27:23Z

Quoting Elaine Zhang (2021-02-28 22:47:49)
> Add the clock tree definition for the new rk3568 SoC.
>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> ---
> drivers/clk/rockchip/Kconfig | 7 +
> drivers/clk/rockchip/Makefile | 1 +
> drivers/clk/rockchip/clk-rk3568.c | 1726 +++++++++++++++++++++++++++++
> drivers/clk/rockchip/clk.h | 30 +-
> 4 files changed, 1763 insertions(+), 1 deletion(-)
> create mode 100644 drivers/clk/rockchip/clk-rk3568.c
>
> diff --git a/drivers/clk/rockchip/Kconfig b/drivers/clk/rockchip/Kconfig
> index effd05032e85..2e31901f4213 100644
> --- a/drivers/clk/rockchip/Kconfig
> +++ b/drivers/clk/rockchip/Kconfig
> @@ -85,4 +85,11 @@ config CLK_RK3399
> default y
> help
> Build the driver for RK3399 Clock Driver.
> +
> +config CLK_RK3568
> + tristate "Rockchip RK3568 clock controller support"
> + depends on (ARM64 || COMPILE_TEST)

Drop parenthesis please.

> + default y
> + help
> + Build the driver for RK3568 Clock Driver.
> endif
> diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
> new file mode 100644
> index 000000000000..60913aa91897
> --- /dev/null
> +++ b/drivers/clk/rockchip/clk-rk3568.c
> @@ -0,0 +1,1726 @@
[...]
> +};
> +builtin_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
> +
> +MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:clk-rk3568");

I think module alias does nothing?