Re: [PATCH v3 0/5] Reset driver for IMX8MQ VPU hardware block

Rob Herring
2021-03-08T18:27:52Z

On Mon, Mar 08, 2021 at 11:22:17AM -0700, Rob Herring wrote:
> On Mon, Mar 01, 2021 at 04:17:49PM +0100, Benjamin Gaignard wrote:
> > The two VPUs inside IMX8MQ share the same control block which can be see
> > as a reset hardware block.
> > In order to be able to add the second VPU (for HECV decoding) it will be
> > more handy if the both VPU drivers instance don't have to share the
> > control block registers. This lead to implement it as an independ reset
> > driver and to change the VPU driver to use it.
> >
> > Please note that this series break the compatibility between the DTB and
> > kernel. This break is limited to IMX8MQ SoC and is done when the driver
> > is still in staging directory.
>
> As this information will be lost, please put in the binding and dts
> patch.

Actually, the adding the VPU reset binding doesn't break compatibility,
so just the dts file changes needs it.

>
> >
> > version 3:
> > - Fix error in VPU example node
> >
> > version 2:
> > - Document the change in VPU bindings
> >
> > Benjamin Gaignard (5):
> > dt-bindings: reset: IMX8MQ VPU reset
> > dt-bindings: media: IMX8MQ VPU: document reset usage
> > reset: Add reset driver for IMX8MQ VPU block
> > media: hantro: Use reset driver
> > arm64: dts: imx8mq: Use reset driver for VPU hardware block
> >
> > .../bindings/media/nxp,imx8mq-vpu.yaml | 14 +-
> > .../bindings/reset/fsl,imx8mq-vpu-reset.yaml | 54 ++++++
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 31 +++-
> > drivers/reset/Kconfig | 8 +
> > drivers/reset/Makefile | 1 +
> > drivers/reset/reset-imx8mq-vpu.c | 169 ++++++++++++++++++
> > drivers/staging/media/hantro/Kconfig | 1 +
> > drivers/staging/media/hantro/imx8m_vpu_hw.c | 61 ++-----
> > include/dt-bindings/reset/imx8mq-vpu-reset.h | 16 ++
> > 9 files changed, 294 insertions(+), 61 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/reset/fsl,imx8mq-vpu-reset.yaml
> > create mode 100644 drivers/reset/reset-imx8mq-vpu.c
> > create mode 100644 include/dt-bindings/reset/imx8mq-vpu-reset.h
> >
> > --
> > 2.25.1
> >