From: Christoph Hellwig <hch@lst.de>
To: Martin Wilck <mwilck@suse.com>
Cc: Daniel Wagner <dwagner@suse.de>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: Suppress uevent for hidden device when removed
Date: Mon, 8 Mar 2021 19:37:51 +0100 [thread overview]
Message-ID: <20210308183751.GA17380@lst.de> (raw)
In-Reply-To: <66a9b7ff4958ab990f58a3dad8152d00c59775ce.camel@suse.com>
On Wed, Mar 03, 2021 at 06:30:34PM +0100, Martin Wilck wrote:
> I wonder if it wouldn't be wiser to remove this code
>
> if (disk->flags & GENHD_FL_HIDDEN) {
> dev_set_uevent_suppress(ddev, 0);
> return;
> }
>
> from register_disk(). The way you did it now, we would receive neither
> "add" nor "remove" events in user space, but there might be change
> events in between ?
Well, we'll need to keep the return. That being said keepign the
uevents supressed entirely might be a good idea.
prev parent reply other threads:[~2021-03-08 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 17:12 [PATCH] block: Suppress uevent for hidden device when removed Daniel Wagner
2021-03-03 17:30 ` Martin Wilck
2021-03-08 18:37 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308183751.GA17380@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox