From: Zack Rusin <zackr@vmware.com>
To: <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Martin Krastev <krastevm@vmware.com>,
Roland Scheidegger <sroland@vmware.com>,
<dri-devel@lists.freedesktop.org>
Subject: [PATCH 0/2] locking/rwsem: Add down_write_interruptible and use it
Date: Mon, 8 Mar 2021 15:54:54 -0500 [thread overview]
Message-ID: <20210308205456.1317366-1-zackr@vmware.com> (raw)
vmwgfx has really ugly implemention of an interruptible lock trying
to match rw sem semantics. By adding a small bit of code implementing
down_write_interruptible to rwsem which already supported
down_read_interruptible we can completely remove all of the custom
code from vmwgfx.
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Will Deacon <will@kernel.org>
Cc: Martin Krastev <krastevm@vmware.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Zack Rusin (2):
locking/rwsem: Add down_write_interruptible
drm/vmwgfx: Remove custom locking code
drivers/gpu/drm/vmwgfx/Makefile | 2 +-
drivers/gpu/drm/vmwgfx/ttm_lock.c | 194 ----------------
drivers/gpu/drm/vmwgfx/ttm_lock.h | 218 ------------------
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 24 +-
drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 4 +-
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 57 +----
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 32 ++-
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 +-
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 10 +-
drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 8 +-
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +-
drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 8 +-
drivers/gpu/drm/vmwgfx/vmwgfx_shader.c | 4 +-
.../gpu/drm/vmwgfx/vmwgfx_simple_resource.c | 4 +-
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 16 +-
include/linux/rwsem.h | 1 +
kernel/locking/rwsem.c | 23 ++
17 files changed, 98 insertions(+), 515 deletions(-)
delete mode 100644 drivers/gpu/drm/vmwgfx/ttm_lock.c
delete mode 100644 drivers/gpu/drm/vmwgfx/ttm_lock.h
--
2.27.0
next reply other threads:[~2021-03-08 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 20:54 Zack Rusin [this message]
2021-03-08 20:54 ` [PATCH 1/2] locking/rwsem: Add down_write_interruptible Zack Rusin
2021-03-09 8:49 ` Peter Zijlstra
2021-03-09 15:37 ` Zack Rusin
2021-03-08 20:54 ` [PATCH 2/2] drm/vmwgfx: Remove custom locking code Zack Rusin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308205456.1317366-1-zackr@vmware.com \
--to=zackr@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=krastevm@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sroland@vmware.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox