From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 092ABC433E6 for ; Mon, 8 Mar 2021 21:16:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF8FC64FA8 for ; Mon, 8 Mar 2021 21:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230525AbhCHVQG (ORCPT ); Mon, 8 Mar 2021 16:16:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:44776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbhCHVPf (ORCPT ); Mon, 8 Mar 2021 16:15:35 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 490CD64FA9; Mon, 8 Mar 2021 21:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615238134; bh=wgi4ixB+/HuhHipnwGcBia2Ldp0HKcclvEzilpijVm4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vp5XNZZWupcAon7ycuZxhO7fdD2GjZ8HsVG6KAu7YXzNE6CSumTw86o0jjNTElkGD rQYw5+VvLDkJDdLCYHkjpMowycO6SFULV4NTRwVwYYkc1IkQoybBhprFpFD/XMuorc i+fQGkTvzlJ1ITGbAGJ52+3bS7n9mpe40E9TBPWo9Wv++IadsEJi5UvyL8WviVu575 vwoE2yz0fVotco38m9DDWDpUIl2b8j0iJlcWw63XuStiKo+fnEmw+zss+NXLvz+IIu WsMe3eIfnTZNF9a0VB2m6juQNa4Qp99U3XR0wCrJinT6YRzgNsIL+r/Y5Y3rbvni/c 5JSH7Tp28mFWA== Date: Mon, 8 Mar 2021 15:15:32 -0600 From: "Gustavo A. R. Silva" To: Marius Zachmann Cc: Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang Message-ID: <20210308211532.GB214076@embeddedor> References: <20210305095359.GA141682@embeddedor> <107682713.BXpLqza3Di@marius> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <107682713.BXpLqza3Di@marius> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 06, 2021 at 11:39:35AM +0100, Marius Zachmann wrote: > On 06.03.21 at 10:53:59 CET, Gustavo A. R. Silva wrote > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of letting the code fall > > through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Acked-by: Guenter Roeck > > Signed-off-by: Gustavo A. R. Silva > > Acked-by: Marius Zachmann Thanks, Marius. -- Gustavo > > > --- > > drivers/hwmon/corsair-cpro.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c > > index 591929ec217a..fa6aa4fc8b52 100644 > > --- a/drivers/hwmon/corsair-cpro.c > > +++ b/drivers/hwmon/corsair-cpro.c > > @@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type, > > default: > > break; > > } > > + break; > > default: > > break; > > } > > > > > >