From: Christoph Hellwig <hch@lst.de>
To: Caleb Connolly <caleb@connolly.tech>
Cc: Christoph Hellwig <hch@lst.de>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
ejb@linux.ibm.com, stanley.chu@mediatek.com, cang@codeaurora.org,
beanhuo@micron.com, jaegeuk@kernel.org, asutoshd@codeaurora.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] scsi: ufshcd: switch to a version macro
Date: Tue, 9 Mar 2021 10:32:26 +0100 [thread overview]
Message-ID: <20210309093226.GA6320@lst.de> (raw)
In-Reply-To: <0c6cff2b-8d56-2b34-837d-b3d8f1fa5ad9@connolly.tech>
On Mon, Mar 08, 2021 at 10:42:43AM +0000, Caleb Connolly wrote:
> >> +#define UFSHCI_VER(major, minor) \
> >> + ((major << 8) + (minor << 4))
> > This needs braces around major and minor. Or better just convert it
> > to an inline function (and use a lower case name).
>
> Other (similar) implementations, like NVME_VS() use a macro here, is an
> inline function just personal preference?
>
> I'm perfectly happy either way, so I'll switch to your suggestion.
In general inline functions are always preferred over non-trivial
macros. Macros are required for a few cases where e.g. otherwise the
include dependencies would turn into a nightmare.
next prev parent reply other threads:[~2021-03-09 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 0:58 scsi: ufshcd: use a macro for UFS versions Caleb Connolly
2021-03-08 0:58 ` [PATCH 1/3] scsi: ufshcd: switch to a version macro Caleb Connolly
2021-03-08 8:00 ` Christoph Hellwig
2021-03-08 10:42 ` Caleb Connolly
2021-03-09 9:32 ` Christoph Hellwig [this message]
2021-03-08 0:58 ` [PATCH 2/3] scsi: ufs: qcom: use UFSHCI_VER macro Caleb Connolly
2021-03-08 0:59 ` [PATCH 3/3] scsi: ufshcd: remove version check Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309093226.GA6320@lst.de \
--to=hch@lst.de \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=caleb@connolly.tech \
--cc=cang@codeaurora.org \
--cc=ejb@linux.ibm.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox