From: Christoph Hellwig <hch@lst.de>
To: Caleb Connolly <caleb@connolly.tech>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
ejb@linux.ibm.com, stanley.chu@mediatek.com, cang@codeaurora.org,
beanhuo@micron.com, jaegeuk@kernel.org, asutoshd@codeaurora.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [RESEND PATCH v2 1/3] scsi: ufshcd: use a function to calculate versions
Date: Tue, 9 Mar 2021 15:55:43 +0100 [thread overview]
Message-ID: <20210309145543.GB14621@lst.de> (raw)
In-Reply-To: <20210309120212.119451-2-caleb@connolly.tech>
On Tue, Mar 09, 2021 at 12:02:47PM +0000, Caleb Connolly wrote:
> +static inline u32 ufshci_version(u32 major, u32 minor) {
> + return (((major) << 8) + ((minor) << 4));
> +}
Kernel style puts the opening curly brace on a separate line. Also
for an inline function adding parentheses is not required (unlike for
macros).
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-03-09 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 12:02 RESEND v2: scsi: ufshcd: use a macro for UFS versions Caleb Connolly
2021-03-09 12:02 ` [RESEND PATCH v2 1/3] scsi: ufshcd: use a function to calculate versions Caleb Connolly
2021-03-09 14:55 ` Christoph Hellwig [this message]
2021-03-09 12:02 ` [RESEND PATCH v2 2/3] scsi: ufs: qcom: use ufshci_version function Caleb Connolly
2021-03-09 12:03 ` [RESEND PATCH v2 3/3] scsi: ufshcd: remove version check Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309145543.GB14621@lst.de \
--to=hch@lst.de \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=caleb@connolly.tech \
--cc=cang@codeaurora.org \
--cc=ejb@linux.ibm.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox