From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0427CC433E0 for ; Tue, 9 Mar 2021 18:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8E9B6523F for ; Tue, 9 Mar 2021 18:18:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbhCISRe (ORCPT ); Tue, 9 Mar 2021 13:17:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231542AbhCISR2 (ORCPT ); Tue, 9 Mar 2021 13:17:28 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6570AC06174A for ; Tue, 9 Mar 2021 10:17:28 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id f12so17579307wrx.8 for ; Tue, 09 Mar 2021 10:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=E2H0Vyvaz315tDwhjzi69+8Sz+mC0Vpp4i0UyuyRi2U=; b=OOOCffOshjfg7+dvyZj59QRnaxsN4ELj/3FpNu0L7www0KXU24C602V8W53cP3q1h8 YOznA5A8YJ8+PXMvIpLiR0tJxCB97xVjEzjjv96krTWoURtbCi6+gBxLZ99MryYRRuxV EEh/mgkmc8+3ZkCXHwreG6QtWdFM9lfX9r77/7wIpUeIcvJ4nMmyVbi357w5DHLolyx6 qQDzymqVvyUG9mQwZmHIsC/28Bsiw+kQnk5xrXAyBiyuneWdnaXH8F59l9IaYUFL4kIJ YwRSUtuiuUrVinGSOd+bTncAFloBSmj51TdwGFVWY0ZAhxyfKyLNBGsDjxf79PuQDflr hxGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=E2H0Vyvaz315tDwhjzi69+8Sz+mC0Vpp4i0UyuyRi2U=; b=kN1F1f2u2Qqkst66/bltKwObAefETkGeyzE9jbCkkAFNCdUwgvK2oRM9KcGZao/cYU SxiJGg4wgcPEwSLjaNIkNl4U89xvy+01RRn0SpHG7T7h+hfYVyoSSXPkYneXqAQhizpI RQPaERTeyEy++bXjFIdO1rwl7OUtJZ9+NHSVBtNHqPJqAcslA1wYECYQhfXD6QcL5uOO zd7v1T7c1x8MttpljbG/XwO2vrfUBe/wfLP/VzrHvRbrQsy34gLEw6qhbcwtSN7cWSTC Le4Yn11mE/ePQUHSw1DxtYiwkQMp98Yt7LpwI16+r1K+HX176oU3TfW/vN54ETlcwxOK JbIw== X-Gm-Message-State: AOAM533DwInPllJykkSfOa3i5NtG5EKloIqc03Ardg4YyIAwdgLBbWW5 D8qJ+QV+kcL55QiZ1pbHh7L1pw== X-Google-Smtp-Source: ABdhPJxFquNSN6BBhA1UcWqdovNTR3F+6NiI5iWL1dYGNi1OySoTQxoOH3OPGovMK29FhpkUKWg1vQ== X-Received: by 2002:a05:6000:2cf:: with SMTP id o15mr29146414wry.184.1615313847207; Tue, 09 Mar 2021 10:17:27 -0800 (PST) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id j14sm23269096wrw.69.2021.03.09.10.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 10:17:26 -0800 (PST) Date: Tue, 9 Mar 2021 18:17:25 +0000 From: Lee Jones To: Rikard Falkeborn Cc: Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH v2] mfd: stmpe: Revert "Constify static struct resource" Message-ID: <20210309181725.GX4931@dell> References: <20210304230709.3217-1-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210304230709.3217-1-rikard.falkeborn@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Mar 2021, Rikard Falkeborn wrote: > In stmpe_devices_init(), the start and end field of these structs are > modified, so they can not be const. Add a comment to those structs that > lacked it to reduce the risk that this happens again. > > This reverts commit 8d7b3a6dac4eae22c58b0853696cbd256966741b. > > Fixes: 8d7b3a6dac4e ("mfd: stmpe: Constify static struct resource") > Reported-by: Andy Shevchenko > Signed-off-by: Rikard Falkeborn > --- > Changes > V1-V2: Add comments to the structs that they are dynamically modified > Rewrite commit message. > > V1: https://lore.kernel.org/lkml/20210302234710.74455-1-rikard.falkeborn@gmail.com/ > > drivers/mfd/stmpe.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog