From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED33AC433E6 for ; Wed, 10 Mar 2021 13:54:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF9D164FE8 for ; Wed, 10 Mar 2021 13:54:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232797AbhCJNxg (ORCPT ); Wed, 10 Mar 2021 08:53:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231571AbhCJNxH (ORCPT ); Wed, 10 Mar 2021 08:53:07 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 991F5C061761 for ; Wed, 10 Mar 2021 05:53:07 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id nh23-20020a17090b3657b02900c0d5e235a8so7525928pjb.0 for ; Wed, 10 Mar 2021 05:53:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=InN9m7hIprfWWBkDrI24e5tae9R+vk+vV3+IqqJrTHk=; b=hley0yp994m20s7olEdzr4zUvmgmfA+s3wM2zyc1EsCKyEFbeVDRMjl/LyikTjjb2/ GSakKCGengIIeWFNg9Zu7w5qmL09Gvx6hxOgmFNtm7dS03pNPbz2PEf8fvaBnTH1bFsl VsV+soMSWTd7HlfHpZIqcCmtcDvcb9bRcqXG+e+vnLJIlDq588Ynbt1IXUtTftYDHClX Vq29xJHDW0eS2QxXGTAeBtczP6p6nVXj/zWCoA6vBXv56MhWBp4VFZ/RCkX7xZ8+/vez GmK009YmJxv/TsI0Xh2Yvce/E0QIJrRr+2gjxRDKXMceum117T+mAtFiHfptINans96K ejpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=InN9m7hIprfWWBkDrI24e5tae9R+vk+vV3+IqqJrTHk=; b=KSzFYYcuUFpLxifgowuq5LC3JVU1ih4nqQsOY4k7eOjoqYTdT70RPThjxQzXpCPr2X 7PpvtMg+LvpRU5qEkvvenFzmdmxjBwYIkIXQt6uK9ybg+48OoeQIlfA07Mu38akYzzUB 0mavDLMpK7qHAlpzEz2H+zWJ8YTb3VtjrHw4N5Cny3PzfEXK02E/LJohCWO7NhV1huzz ZR4nt+gfyOUQZLedg0xlvThQxVEZk55pk6f+54s1v9+UxF0utPnbqZ5Gi5WoJO3ZwO99 biohWhkeVr3cmczgdz2pTrqKphKPJ0DXBebHbMC41nqRyKzi/GAbn8VlmdEMZo/DY+7m UtcA== X-Gm-Message-State: AOAM531tfWYpkjx6isZIz69h3I0VKYY8LyCq7n3jClDBtjGXMs2e+neX f3nxPSg16wdxz8Flw6tuGR+r X-Google-Smtp-Source: ABdhPJy9D3b4xRKPH7Fw5bprufQUEXAOSRHXuKvGxwnap5Z9PaIf4V/bUoxe86dq6v+VfzZuHYbHZA== X-Received: by 2002:a17:90a:7182:: with SMTP id i2mr3666760pjk.111.1615384387119; Wed, 10 Mar 2021 05:53:07 -0800 (PST) Received: from thinkpad ([103.66.79.59]) by smtp.gmail.com with ESMTPSA id 35sm16050113pgr.14.2021.03.10.05.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 05:53:06 -0800 (PST) Date: Wed, 10 Mar 2021 19:23:01 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, carl.yin@quectel.com, naveen.kumar@quectel.com, loic.poulain@linaro.org Subject: Re: [PATCH v3] bus: mhi: core: Add missing checks for MMIO register entries Message-ID: <20210310135301.GN30275@thinkpad> References: <1615315490-36017-1-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1615315490-36017-1-git-send-email-bbhatt@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 09, 2021 at 10:44:50AM -0800, Bhaumik Bhatt wrote: > As per documentation, fields marked as (required) in an MHI > controller structure need to be populated by the controller driver > before calling mhi_register_controller(). Ensure all required > pointers and non-zero fields are present in the controller before > proceeding with the registration. > > Signed-off-by: Bhaumik Bhatt Applied to mhi-next! Thanks, Mani > --- > v3: removed fw_image as not all controllers require it > v2: removed iova_start and iova_stop as they can be zero > > drivers/bus/mhi/core/init.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c > index 272f350..d8882b3 100644 > --- a/drivers/bus/mhi/core/init.c > +++ b/drivers/bus/mhi/core/init.c > @@ -879,12 +879,10 @@ int mhi_register_controller(struct mhi_controller *mhi_cntrl, > u32 soc_info; > int ret, i; > > - if (!mhi_cntrl) > - return -EINVAL; > - > - if (!mhi_cntrl->runtime_get || !mhi_cntrl->runtime_put || > + if (!mhi_cntrl || !mhi_cntrl->cntrl_dev || !mhi_cntrl->regs || > + !mhi_cntrl->runtime_get || !mhi_cntrl->runtime_put || > !mhi_cntrl->status_cb || !mhi_cntrl->read_reg || > - !mhi_cntrl->write_reg || !mhi_cntrl->nr_irqs) > + !mhi_cntrl->write_reg || !mhi_cntrl->nr_irqs || !mhi_cntrl->irq) > return -EINVAL; > > ret = parse_config(mhi_cntrl, config); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >