From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4284C433E9 for ; Wed, 10 Mar 2021 14:09:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B5C464F45 for ; Wed, 10 Mar 2021 14:09:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232912AbhCJOIh (ORCPT ); Wed, 10 Mar 2021 09:08:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232849AbhCJOID (ORCPT ); Wed, 10 Mar 2021 09:08:03 -0500 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77157C061761 for ; Wed, 10 Mar 2021 06:08:03 -0800 (PST) Received: by mail-pg1-x52b.google.com with SMTP id p21so11477302pgl.12 for ; Wed, 10 Mar 2021 06:08:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1dnlnnG6guD+k60v0FjgIQ9Tl0jScXDP+aIyOD9ZKPM=; b=GjngrHxG9FWe61VRrJrlxC4tkNTga3gHgNntUI85TOQDpxUl7QniRLvNaTEunqxIpq YelY/uEze7X1rZIqJq00Ty4RcWMrwkb4Mf2wl23W9+VRqoo2fYofBnQ/MLENGCEi7r/7 tP1gXGhPhmuPHhYqL4fpBYfX1Cn0K7iuqbeejI0Nu9zI1B9t3Y+E+bJ31rWeAdMuVq4r 52elek1Osb+ui0lAavWCzYXIE5HrUleeiAU9KYnqSR2GIX4YW34UY74okWeuA8dHQbLg pEdP1MvMY9dtj/mWCz3lNFkBGC5M1OlzYbFWhj+LjIldCGOBJgnw+z6gh1wzI2FgP3NC 1nhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1dnlnnG6guD+k60v0FjgIQ9Tl0jScXDP+aIyOD9ZKPM=; b=pIg0TteHoU0/E+IjWGF0e7gpmjvSOJLveSaz3ZwHPEVsoYJFmhO+Xusayo4UN36eMH 5cQT2MJauQkIudfCfqasoePQu7nfc6kGqAHTFahTfFWFlfnieK1VS7p5UnEbnTljt7eU oaxL8mrfDpUJy6aBpSnxwnn/LSCl5IWOmLWso60lYsx5AJXeytZjVeMSTqFlbZJ6EsKj w97NPfzNu8qWDrkMjKVRior98N6lHJsIgWO0Yiaz+mHbIgYnKtsfJMLgeOL3u8NHeJxS IHN+uFaSUGuwFVmhrsWgWkpeE5Ov0qodvTXfB7PaNKdJP0uGXVqLr1H5u6pH8dTQL6QH CfCg== X-Gm-Message-State: AOAM533UsrGtMDnCHnvNI6uyj6eMqPhM0i92qrYEgRHicontjWcJ087c TBhUTxnUHwH1SPQcr5J+XUGFngvz9zRLzdA= X-Google-Smtp-Source: ABdhPJzB3BEVU7GeZTLogAHSOrU0BB2nEVrffSEQzYG+GiguZDb0u64v6wwiRKp1s7M67qmah8Wlfw== X-Received: by 2002:aa7:9989:0:b029:1f5:aa05:94af with SMTP id k9-20020aa799890000b02901f5aa0594afmr3045232pfh.34.1615385282806; Wed, 10 Mar 2021 06:08:02 -0800 (PST) Received: from thinkpad ([103.66.79.59]) by smtp.gmail.com with ESMTPSA id m3sm15895961pgk.47.2021.03.10.06.07.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 06:08:02 -0800 (PST) Date: Wed, 10 Mar 2021 19:37:56 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, carl.yin@quectel.com, naveen.kumar@quectel.com Subject: Re: [PATCH v6 0/4] Serialize execution environment changes for MHI Message-ID: <20210310140756.GR30275@thinkpad> References: <1614208985-20851-1-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614208985-20851-1-git-send-email-bbhatt@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24, 2021 at 03:23:01PM -0800, Bhaumik Bhatt wrote: > v6: > -Add patch to improve debug message > -Fix switch-case fall through warning for EE serialization patch > -Address review comments and update commit text > > v5: > -Update commit text for "clear devices when moving execution environments" patch > -Added test platform details that were missed out in the cover letter > -Merged two if checks in to a single one for EE serialization patch > > v4: > -Addressed review comments for additional info logging for EE movements > -Updated switch case for EE handling in mhi_intvec_threaded_handler() > > v3: > -Update commit text to accurately reflect changes and reasoning based on reviews > > v2: > -Add patch to clear devices when moving execution environments > > Note: This patch is first in series of execution environment related changes. > > During full boot chain firmware download, the PM state worker downloads the AMSS > image after waiting for the SBL execution environment change in PBL mode itself. > Since getting rid of the firmware load worker thread, this design needs to > change and MHI host must download the AMSS image from the SBL mode of PM state > worker thread instead of blocking waits for SBL EE in PBL transition processing. > > Ensure that EE changes are handled only from appropriate places and occur > one after another and handle only PBL or RDDM EE changes as critical events > directly from the interrupt handler and the status callback is given to the > controller drivers promptly. > > When moving from SBL to AMSS EE, clear SBL specific client devices by calling > remove callbacks for them so they are not left opened in a different execution > environment. > > This patchset was tested on ARM64. > Series applied to mhi-next! Thanks, Mani > Bhaumik Bhatt (4): > bus: mhi: core: Destroy SBL devices when moving to mission mode > bus: mhi: core: Download AMSS image from appropriate function > bus: mhi: core: Process execution environment changes serially > bus: mhi: core: Update debug prints to include local device state > > drivers/bus/mhi/core/boot.c | 51 +++++++++++++-------------- > drivers/bus/mhi/core/internal.h | 1 + > drivers/bus/mhi/core/main.c | 76 +++++++++++++++++++++++++++-------------- > drivers/bus/mhi/core/pm.c | 10 ++++-- > 4 files changed, 83 insertions(+), 55 deletions(-) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >