From: Christoph Hellwig <hch@infradead.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Sam Ravnborg <sam@ravnborg.org>,
od@zcrc.me, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v2 1/5] drm: Add and export function drm_gem_cma_create_noncoherent
Date: Thu, 11 Mar 2021 12:23:30 +0000 [thread overview]
Message-ID: <20210311122330.GA1739082@infradead.org> (raw)
In-Reply-To: <20210307202835.253907-2-paul@crapouillou.net>
> +static struct drm_gem_cma_object *
> +drm_gem_cma_create_with_cache_param(struct drm_device *drm,
> + size_t size,
> + bool noncoherent)
Does this helper really make much sense? You basically have two
function calls in it, out of which one is dependend on the parameter.
next prev parent reply other threads:[~2021-03-11 12:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 20:28 [PATCH v2 0/5] Add option to mmap GEM buffers cached Paul Cercueil
2021-03-07 20:28 ` [PATCH v2 1/5] drm: Add and export function drm_gem_cma_create_noncoherent Paul Cercueil
2021-03-11 12:23 ` Christoph Hellwig [this message]
2021-03-07 20:28 ` [PATCH v2 2/5] drm: Add and export function drm_gem_cma_dumb_create_noncoherent Paul Cercueil
2021-03-07 20:28 ` [PATCH v2 3/5] drm: Add and export function drm_gem_cma_mmap_noncoherent Paul Cercueil
2021-03-11 12:26 ` Christoph Hellwig
2021-03-11 12:32 ` Paul Cercueil
2021-03-11 12:36 ` Christoph Hellwig
2021-03-11 16:12 ` Paul Cercueil
2021-03-12 16:36 ` Christoph Hellwig
2021-03-07 20:28 ` [PATCH v2 4/5] drm: Add and export function drm_gem_cma_sync_data Paul Cercueil
2021-03-11 12:28 ` Christoph Hellwig
2021-03-11 12:33 ` Paul Cercueil
2021-03-15 7:43 ` Thomas Zimmermann
2021-03-15 11:59 ` Paul Cercueil
2021-03-07 20:28 ` [PATCH v2 5/5] drm/ingenic: Add option to alloc cached GEM buffers Paul Cercueil
[not found] ` <20210308034727.1951-1-hdanton@sina.com>
2021-03-10 19:01 ` Paul Cercueil
[not found] ` <20210311022743.2542-1-hdanton@sina.com>
2021-03-11 12:10 ` Paul Cercueil
2021-03-11 12:30 ` Christoph Hellwig
2021-03-11 13:40 ` Paul Cercueil
2021-03-08 8:41 ` [PATCH v2 0/5] Add option to mmap GEM buffers cached Thomas Zimmermann
2021-03-10 19:02 ` Paul Cercueil
2021-03-11 7:52 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311122330.GA1739082@infradead.org \
--to=hch@infradead.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox