Re: [PATCH] infiniband/i40iw: Fix a use after free in i40iw_cm_event_handler

Jason Gunthorpe
2021-03-11T18:23:05Z

On Wed, Mar 10, 2021 at 07:14:14PM -0800, Lv Yunlong wrote:
> In the case of I40IW_CM_EVENT_ABORTED, i40iw_event_connect_error()
> could be called to free the event->cm_node. However, event->cm_node
> will be used after and cause use after free. It needs to add flags
> to inform that event->cm_node has been freed.
>
> Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
> ---
> drivers/infiniband/hw/i40iw/i40iw_cm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)

This might be OK (though I don't like the free variable), Shiraz??

Jason