Re: [PATCH 05/17] workqueue: cfi: disable callback pointer check with modules

Kees Cook
2021-03-12T02:43:55Z

On Thu, Mar 11, 2021 at 04:49:07PM -0800, Sami Tolvanen wrote:
> With CONFIG_CFI_CLANG, a callback function passed to
> __queue_delayed_work from a module points to a jump table entry
> defined in the module instead of the one used in the core kernel,
> which breaks function address equality in this check:
>
> WARN_ON_ONCE(timer->function != delayed_work_timer_fn);
>
> Disable the warning when CFI and modules are enabled.

Reviewed-by: Kees Cook <keescook@chromium.org>

--
Kees Cook