From: Badhri Jagan Sridharan <badhri@google.com>
To: Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyle Tso <kyletso@google.com>,
Badhri Jagan Sridharan <badhri@google.com>
Subject: [PATCH v2 1/2] usb: typec: tcpci: Add tcpc chip level callbacks
Date: Thu, 11 Mar 2021 21:24:42 -0800 [thread overview]
Message-ID: <20210312052443.3797674-1-badhri@google.com> (raw)
This change adds chip callbacks for the following operations:
1. Notifying port role
2. Notifying orientation
Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
---
Changes since V1:
- Dropped changes related to get_/set_current_limit and pd_capable
callback. Will send them in as separate patches.
---
drivers/usb/typec/tcpm/tcpci.c | 12 +++++++++++-
drivers/usb/typec/tcpm/tcpci.h | 10 ++++++++++
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
index 027afd7dfdce..c37bbb2e9961 100644
--- a/drivers/usb/typec/tcpm/tcpci.c
+++ b/drivers/usb/typec/tcpm/tcpci.c
@@ -265,9 +265,16 @@ static int tcpci_set_polarity(struct tcpc_dev *tcpc,
if (ret < 0)
return ret;
- return regmap_write(tcpci->regmap, TCPC_TCPC_CTRL,
+ ret = regmap_write(tcpci->regmap, TCPC_TCPC_CTRL,
(polarity == TYPEC_POLARITY_CC2) ?
TCPC_TCPC_CTRL_ORIENTATION : 0);
+ if (ret < 0)
+ return ret;
+
+ if (tcpci->data->set_cc_polarity)
+ tcpci->data->set_cc_polarity(tcpci, tcpci->data, polarity);
+
+ return ret;
}
static void tcpci_set_partner_usb_comm_capable(struct tcpc_dev *tcpc, bool capable)
@@ -395,6 +402,9 @@ static int tcpci_set_roles(struct tcpc_dev *tcpc, bool attached,
if (ret < 0)
return ret;
+ if (tcpci->data->set_roles)
+ tcpci->data->set_roles(tcpci, tcpci->data, attached, role, data);
+
return 0;
}
diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h
index 57b6e24e0a0c..75a2c9b575b5 100644
--- a/drivers/usb/typec/tcpm/tcpci.h
+++ b/drivers/usb/typec/tcpm/tcpci.h
@@ -165,6 +165,12 @@ struct tcpci;
* Optional; The USB Communications Capable bit indicates if port
* partner is capable of communication over the USB data lines
* (e.g. D+/- or SS Tx/Rx). Called to notify the status of the bit.
+ * @set_roles:
+ * Optional; This callback notifies the TCPC driver of the resolved
+ * port role and attached status.
+ * @set_cc_polarity:
+ * Optional; This callback notifies the TCPC driver of the resolved
+ * polarity.
*/
struct tcpci_data {
struct regmap *regmap;
@@ -181,6 +187,10 @@ struct tcpci_data {
void (*frs_sourcing_vbus)(struct tcpci *tcpci, struct tcpci_data *data);
void (*set_partner_usb_comm_capable)(struct tcpci *tcpci, struct tcpci_data *data,
bool capable);
+ void (*set_roles)(struct tcpci *tcpci, struct tcpci_data *data, bool attached,
+ enum typec_role role, enum typec_data_role data_role);
+ void (*set_cc_polarity)(struct tcpci *tcpci, struct tcpci_data *data,
+ enum typec_cc_polarity polarity);
};
struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data);
--
2.31.0.rc2.261.g7f71774620-goog
next reply other threads:[~2021-03-12 5:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 5:24 Badhri Jagan Sridharan [this message]
2021-03-12 5:24 ` [PATCH v2 2/2] usb: typec: tcpci_maxim: configure charging & data paths Badhri Jagan Sridharan
2021-03-12 6:39 ` Guenter Roeck
2021-03-12 7:04 ` Badhri Jagan Sridharan
2021-03-12 9:01 ` Heikki Krogerus
2021-03-12 6:33 ` [PATCH v2 1/2] usb: typec: tcpci: Add tcpc chip level callbacks Greg Kroah-Hartman
2021-03-12 6:34 ` Greg Kroah-Hartman
2021-03-12 7:06 ` Badhri Jagan Sridharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312052443.3797674-1-badhri@google.com \
--to=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox