From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403E8C433E0 for ; Fri, 12 Mar 2021 10:51:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B5D260C3D for ; Fri, 12 Mar 2021 10:51:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233468AbhCLKvC (ORCPT ); Fri, 12 Mar 2021 05:51:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:36810 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233620AbhCLKuo (ORCPT ); Fri, 12 Mar 2021 05:50:44 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F174B65021; Fri, 12 Mar 2021 10:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615546244; bh=fgKpPGWl7vdkjYlq9KFgP4TmOGenokxAgG3aU4o71JY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EGkoAHZ79zm0HpbPJC1fOXOeeVwESsGko2HmFJdypim7agTxOBhI1QIl8NgHn4jnH u1lKjyKNHRY3jwRJnAwgFSfErfSW0fHdFR6Bk4BGeOczdoGAKSyOi/PDMVsedTUcZV rppAP5450ZSZ5geAA3vLXaZ0eoMnCWYxD8alfsUsNGMCd8v22EEYtlyxCFmcskiK4y 0E5YAPYum2/u5+gjOAOizGwbK5UALblRhWac40JBSs5fZDkdMRvvcTsktyBo/DiIAM PqAAV0xM5DD8d04jkpkKLMTvaSzBtrJ/G04MY5mAbdMDc+sp2JdixHQIGb3WNBN94t W5Napa7mNglcA== Date: Fri, 12 Mar 2021 10:49:31 +0000 From: Mark Brown To: Daniel Baluta Cc: Daniel Baluta , Linux-ALSA , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Linux Kernel Mailing List , dl-linux-imx , Ranjani Sridharan , Pierre-Louis Bossart , "S.j. Wang" , Daniel Baluta Subject: Re: [PATCH] ASoC: core: Don't set platform name when of_node is set Message-ID: <20210312104931.GA5348@sirena.org.uk> References: <20210309082328.38388-1-daniel.baluta@oss.nxp.com> <20210309153455.GB4878@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/" Content-Disposition: inline In-Reply-To: X-Cookie: Lake Erie died for your sins. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 12, 2021 at 10:32:54AM +0200, Daniel Baluta wrote: > On Tue, Mar 9, 2021 at 5:38 PM Mark Brown wrote: > > > + if (!dai_link->platforms->of_node) > > > + dai_link->platforms->name = component->name; > > Why would we prefer the node name over something explicitly configured? > Not sure I follow your question. I think the difference stands in the > way we treat OF vs non-OF platforms. If an explicit name has been provided why would we override it with an autogenerated one? --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBLRzoACgkQJNaLcl1U h9DHLgf/dCrl7QiN+jfF0cGbC1JdfYVq4HAVtswUrQEnPISDtyOBMpD2WjMCmM8j mAv2nD3wC8p0mFgDWKn/KEcmsj7KXiFO3sD63kQsiolJrk5rTX5NAtvHeVuXxZ8+ yQVlP6G8CVpAcjk6CcKpEtWp+cT1H2uDXq4XyGzILCfzlPNqfRRLU9wZesvB3mtS mpd1v/6aN6iXcbKYQWzD4jR70WsTAJw3IFcUtJCGejos6hHYSsrdhD8rPuT59WY7 T/lXXFVZM7+nwbd5AeL/CqlldmKcS40nfRevG9GbIkpm37kFdWvk0g1shf83owPB 6HOiE4Gctdl3DTxDYJgLfMNNXrZF/w== =pOj0 -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/--