public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiang Biao <benbjiang@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	robinlai@tencent.com, benbjiang@tencent.com
Subject: [PATCH] mm/oom_kill: fix wild pointer in out_of_memory
Date: Sat, 13 Mar 2021 12:23:00 +0800	[thread overview]
Message-ID: <20210313042300.3833-1-benbjiang@gmail.com> (raw)

From: Bin Lai <robinlai@tencent.com>

From: Bin Lai <robinlai@tencent.com>

The oc->chosen is used by oom implementation, and the caller does
not initialize this variable. If the tasks of memcg are all unkillable,
oom_evaluate_task cann't choose any task, and the oc->chosen will be
a wild pointer. So we should initialize oc->chosen before calling
oom_evaluate_task.

Signed-off-by: Bin Lai <robinlai@tencent.com>
Reviewed-by: Jiang Biao <benbjiang@tencent.com>

diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 9efaf43..0658a30 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -366,6 +366,7 @@ static int oom_evaluate_task(struct task_struct *task, void *arg)
 static void select_bad_process(struct oom_control *oc)
 {
 	oc->chosen_points = LONG_MIN;
+	oc->chosen = NULL;
 
 	if (is_memcg_oom(oc))
 		mem_cgroup_scan_tasks(oc->memcg, oom_evaluate_task, oc);
-- 
1.8.3.1


             reply	other threads:[~2021-03-13  4:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13  4:23 Jiang Biao [this message]
2021-03-15  8:22 ` [PATCH] mm/oom_kill: fix wild pointer in out_of_memory Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210313042300.3833-1-benbjiang@gmail.com \
    --to=benbjiang@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=benbjiang@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=robinlai@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox