Re: [PATCH net-next v1] mfd: Add Renesas Synchronization Management Unit (SMU) support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2843 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/min-li-xe-renesas-com/mfd-Add-Renesas-Synchronization-Management-Unit-SMU-support/20210314-014512
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5ab6f96a12f4f28d5a283dcf46b004cc653246a1
config: i386-randconfig-s032-20210314 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-262-g5e674421-dirty
        # https://github.com/0day-ci/linux/commit/4d537d85df739a32487e30fb69388b030577cb42
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review min-li-xe-renesas-com/mfd-Add-Renesas-Synchronization-Management-Unit-SMU-support/20210314-014512
        git checkout 4d537d85df739a32487e30fb69388b030577cb42
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/mfd/rsmu_spi.o: in function `rsmu_read':
>> drivers/mfd/rsmu_spi.c:187: multiple definition of `rsmu_read'; drivers/mfd/rsmu_i2c.o:drivers/mfd/rsmu_i2c.c:171: first defined here
   ld: drivers/mfd/rsmu_spi.o: in function `rsmu_write':
>> drivers/mfd/rsmu_spi.c:206: multiple definition of `rsmu_write'; drivers/mfd/rsmu_i2c.o:drivers/mfd/rsmu_i2c.c:179: first defined here


vim +187 drivers/mfd/rsmu_spi.c

   185	
   186	int rsmu_read(struct device *dev, u16 reg, u8 *buf, u16 size)
 > 187	{
   188		struct rsmu_dev *rsmu = dev_get_drvdata(dev);
   189		u8 addr = (u8)(reg & RSMU_LOWER_ADDR_MASK);
   190		int err;
   191	
   192		err = rsmu_write_page_register(rsmu, reg);
   193		if (err)
   194			return err;
   195	
   196		err = rsmu_read_device(rsmu, addr, buf, size);
   197		if (err)
   198			dev_err(rsmu->dev,
   199				"failed to read offset address 0x%x\n", addr);
   200	
   201		return err;
   202	}
   203	EXPORT_SYMBOL_GPL(rsmu_read);
   204	
   205	int rsmu_write(struct device *dev, u16 reg, u8 *buf, u16 size)
 > 206	{
   207		struct rsmu_dev *rsmu = dev_get_drvdata(dev);
   208		u8 addr = (u8)(reg & RSMU_LOWER_ADDR_MASK);
   209		int err;
   210	
   211		err = rsmu_write_page_register(rsmu, reg);
   212		if (err)
   213			return err;
   214	
   215		err = rsmu_write_device(rsmu, addr, buf, size);
   216		if (err)
   217			dev_err(rsmu->dev,
   218				"failed to write offset address 0x%x\n", addr);
   219	
   220		return err;
   221	}
   222	EXPORT_SYMBOL_GPL(rsmu_write);
   223	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36681 bytes --]