From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E3F7C433DB for ; Mon, 15 Mar 2021 10:28:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B988B64E89 for ; Mon, 15 Mar 2021 10:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229901AbhCOK2K (ORCPT ); Mon, 15 Mar 2021 06:28:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:38044 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbhCOK1o (ORCPT ); Mon, 15 Mar 2021 06:27:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8737DAD72; Mon, 15 Mar 2021 10:27:43 +0000 (UTC) Date: Mon, 15 Mar 2021 11:27:40 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Vlastimil Babka , Michal Hocko , Muchun Song , Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Anshuman Khandual Subject: Re: [PATCH v4 0/4] Make alloc_contig_range handle Hugetlb pages Message-ID: <20210315102740.GB25101@linux> References: <20210310150853.13541-1-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 10:06:40AM +0100, David Hildenbrand wrote: > > BTW, I stumbled yesterday over > > alloc_contig_pages()->pfn_range_valid_contig(): > > if (page_count(page) > 0) > rerurn false; > if (PageHuge(page)) > return false; > > As used by memtrace and for gigantic pages. We can now > > a) Drop these check completely, as it's best-effort only and racy. > alloc_contig_pages()/alloc_contig_range() will handle it properly. > > b) Similarly, check for gigantic pages and/or movability/migratability. > > Dropping both checks might be the right thing to do: might significantly > increase allocation chances -- as we actually end up migrating busy pages > ... Oh, sorry David, my mail client tricked me and I did not see this till now. I will have a look, but I would like to collect some more feedback from all pieces before going any further and write a new version. Vlastimil patch#1 and patch#2 and he was ok with them, but let see what others think as well. -- Oscar Salvador SUSE L3