From: Andreas Kemnade <andreas@kemnade.info>
To: Lee Jones <lee.jones@linaro.org>
Cc: j.neuschaefer@gmx.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD
Date: Mon, 15 Mar 2021 13:28:25 +0100 [thread overview]
Message-ID: <20210315132819.0970d493@aktux> (raw)
In-Reply-To: <20210315081231.GX701493@dell>
On Mon, 15 Mar 2021 08:12:31 +0000
Lee Jones <lee.jones@linaro.org> wrote:
[...]
> > static int ntxec_probe(struct i2c_client *client)
> > {
> > struct ntxec *ec;
> > unsigned int version;
> > int res;
> > + const struct mfd_cell *subdevs = ntxec_subdev;
> > + size_t n_subdevs = ARRAY_SIZE(ntxec_subdev);
>
> This is a little confusing. I had to re-read to figure it out.
>
> In my mind, it would be clearer to explicitly set these in the
> switch, rather than have a default which can be over-written.
>
yes, it is clearer. I was just afraid that your compiler cannot
figure it out that things get initialized and getting comments like
"This code has never seen a compiler."
But I will throw it against several ones.
Regards,
Andreas
next prev parent reply other threads:[~2021-03-15 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 10:42 [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD Andreas Kemnade
2021-03-13 11:25 ` Jonathan Neuschäfer
2021-03-15 8:12 ` Lee Jones
2021-03-15 12:28 ` Andreas Kemnade [this message]
2021-03-15 14:20 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315132819.0970d493@aktux \
--to=andreas@kemnade.info \
--cc=j.neuschaefer@gmx.net \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox