From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D59EC4332D for ; Tue, 16 Mar 2021 03:39:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53C3A6503B for ; Tue, 16 Mar 2021 03:39:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233581AbhCPDiB (ORCPT ); Mon, 15 Mar 2021 23:38:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229871AbhCPDh4 (ORCPT ); Mon, 15 Mar 2021 23:37:56 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98443C061756 for ; Mon, 15 Mar 2021 20:37:56 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id cl21-20020a17090af695b02900c61ac0f0e9so2934088pjb.1 for ; Mon, 15 Mar 2021 20:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=D0BAFysH7qL4LFoBg75GBctRM5jSEuwatot3WxQhxec=; b=HcWXZvS7r20fk9uy6+Tp7Sj9tGQ3uBbzqPP9Y1bxIJozWtScnQryXzDZ46MXHn27Vm ce/m9xmU2wfGztiowmH0hWP0E1fUV3WQnMX9FM0ySoC6tXOCkOXcb1849eHKdPyJZkGH iZCMES+ByVxau6hxYUK60VzJi0AXWV3PY9sEv4M4fbxDeaDDvesRyYwvancIoZyFV0oN SLemja+/3zlImtr7878oDHJ3FqBxpO3cSZWh3VWuzo0PCsIiCsrXDpb1KNVSlXvMkZo3 B1fVCq+x7nmE/CFRA0XKMTVbPiPYUNEQsArrIF8hymhtNGaPz5KXfsCkoZGn39kjTU7N fJDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=D0BAFysH7qL4LFoBg75GBctRM5jSEuwatot3WxQhxec=; b=JrCgnKiDOB6kPLlH3KQZTwvCIQUDKyeasYqSrhMobliYx4XiyDMo32YdYrAFlCQG+6 MCvjdPHgbnB2/1rH8dLlURbtEGtWynCA8EiLc15+f2hmy7izDwcX/i09SrD4jyqQ+NYi wmNpZOA1FIZqBFe2PCwdp7ezYEAvQoh50ghc8Nvewaev0y+VTH5YEM25WDQcA1klAGjF 6wuafnhM7Ot2vU5oYDmpyofY0VU4Zm45k/X70CFSoyU42dWAvBIGPy6qscuI32ed/D7k EsV5C8/l+DUEY6J8hSoEPLN0TC85U1hMRDAdOV2cI2YhtcvdcD7TFmQ/7CZ09LALXnaN maLA== X-Gm-Message-State: AOAM532QjJeQcmV70U+Ll1Gbvsfw1KtJU8QJy4dP6xN/aUZ5+SRDlvMx 6GanO3XsROK29NCjWUGu/3tu X-Google-Smtp-Source: ABdhPJyvRDPd5npK4k/hb/oqXewaWLQEt4ZzgK65SexKt4oGbDqiew6RjYf9e77ckiFpgkhpqywGQw== X-Received: by 2002:a17:90a:6be4:: with SMTP id w91mr2716772pjj.68.1615865875875; Mon, 15 Mar 2021 20:37:55 -0700 (PDT) Received: from work ([103.66.79.72]) by smtp.gmail.com with ESMTPSA id x190sm14525096pfx.60.2021.03.15.20.37.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Mar 2021 20:37:55 -0700 (PDT) Date: Tue, 16 Mar 2021 09:07:50 +0530 From: Manivannan Sadhasivam To: Alex Elder Cc: davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/3] net: ipa: fix a duplicated tlv_type value Message-ID: <20210316033750.GC29414@work> References: <20210315152112.1907968-1-elder@linaro.org> <20210315152112.1907968-2-elder@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315152112.1907968-2-elder@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 15, 2021 at 10:21:10AM -0500, Alex Elder wrote: > In the ipa_indication_register_req_ei[] encoding array, the tlv_type > associated with the ipa_mhi_ready_ind field is wrong. It duplicates > the value used for the data_usage_quota_reached field (0x11) and > should use value 0x12 instead. Fix this bug. > > Reported-by: Manivannan Sadhasivam > Signed-off-by: Alex Elder Acked-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/net/ipa/ipa_qmi_msg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ipa/ipa_qmi_msg.c b/drivers/net/ipa/ipa_qmi_msg.c > index 73413371e3d3e..e00f829a783f6 100644 > --- a/drivers/net/ipa/ipa_qmi_msg.c > +++ b/drivers/net/ipa/ipa_qmi_msg.c > @@ -56,7 +56,7 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = { > .elem_size = > sizeof_field(struct ipa_indication_register_req, > ipa_mhi_ready_ind_valid), > - .tlv_type = 0x11, > + .tlv_type = 0x12, > .offset = offsetof(struct ipa_indication_register_req, > ipa_mhi_ready_ind_valid), > }, > @@ -66,7 +66,7 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = { > .elem_size = > sizeof_field(struct ipa_indication_register_req, > ipa_mhi_ready_ind), > - .tlv_type = 0x11, > + .tlv_type = 0x12, > .offset = offsetof(struct ipa_indication_register_req, > ipa_mhi_ready_ind), > }, > -- > 2.27.0 >