Re: [PATCH v2 09/12] docs: path-lookup: no get_link()

NeilBrown
2021-04-19T01:41:16Z

[-- Attachment #1: Type: text/plain, Size: 1965 bytes --]

On Tue, Mar 16 2021, Fox Chen wrote:

> no get_link() anymore. we have step_into() and pick_link().
>
> walk_component() will call step_into(), in turn call pick_link,
> and return symlink name.
>
> Signed-off-by: Fox Chen <foxhlchen@gmail.com>
> ---
> Documentation/filesystems/path-lookup.rst | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/filesystems/path-lookup.rst b/Documentation/filesystems/path-lookup.rst
> index 8ab95dd9046e..0d41c61f7e4f 100644
> --- a/Documentation/filesystems/path-lookup.rst
> +++ b/Documentation/filesystems/path-lookup.rst
> @@ -1103,12 +1103,10 @@ doesn't need to notice. Getting this ``name`` variable on and off the
> stack is very straightforward; pushing and popping the references is
> a little more complex.
>
> -When a symlink is found, ``walk_component()`` returns the value ``1``
> -(``0`` is returned for any other sort of success, and a negative number
> -is, as usual, an error indicator). This causes ``get_link()`` to be
> -called; it then gets the link from the filesystem. Providing that
> -operation is successful, the old path ``name`` is placed on the stack,
> -and the new value is used as the ``name`` for a while. When the end of
> +When a symlink is found, ``walk_component()`` calls ``pick_link()``,

walk_component() calls pick_link() via step_into()
??

> +it then gets the link from the filesystem returning new path ``name``.

"which returns the link from the filesystem."

With those changes (assuming you agree with them)

Reviewed-by: NeilBrown <neilb@suse.de>

Thanks,
NeilBrown

> +Providing that operation is successful, the old path ``name`` is placed on the
> +stack, and the new value is used as the ``name`` for a while. When the end of
> the path is found (i.e. ``*name`` is ``'\0'``) the old ``name`` is restored
> off the stack and path walking continues.
>
> --
> 2.30.2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]