* [PATCH v3 RESEND] bus: mhi: core: Return EAGAIN if MHI ring is full
@ 2021-03-10 20:40 Jeffrey Hugo
2021-03-16 6:06 ` Manivannan Sadhasivam
0 siblings, 1 reply; 2+ messages in thread
From: Jeffrey Hugo @ 2021-03-10 20:40 UTC (permalink / raw)
To: manivannan.sadhasivam, hemantk
Cc: bbhatt, linux-arm-msm, linux-kernel, Fan Wu, Jeffrey Hugo
From: Fan Wu <wufan@codeaurora.org>
Currently ENOMEM is returned when MHI ring is full. This error code is
very misleading. Change to EAGAIN instead.
Signed-off-by: Fan Wu <wufan@codeaurora.org>
Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/bus/mhi/core/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
index 2c61dfd..a7811fb 100644
--- a/drivers/bus/mhi/core/main.c
+++ b/drivers/bus/mhi/core/main.c
@@ -1020,7 +1020,7 @@ static int mhi_queue(struct mhi_device *mhi_dev, struct mhi_buf_info *buf_info,
ret = mhi_is_ring_full(mhi_cntrl, tre_ring);
if (unlikely(ret)) {
- ret = -ENOMEM;
+ ret = -EAGAIN;
goto exit_unlock;
}
--
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v3 RESEND] bus: mhi: core: Return EAGAIN if MHI ring is full
2021-03-10 20:40 [PATCH v3 RESEND] bus: mhi: core: Return EAGAIN if MHI ring is full Jeffrey Hugo
@ 2021-03-16 6:06 ` Manivannan Sadhasivam
0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2021-03-16 6:06 UTC (permalink / raw)
To: Jeffrey Hugo; +Cc: hemantk, bbhatt, linux-arm-msm, linux-kernel, Fan Wu
On Wed, Mar 10, 2021 at 01:40:03PM -0700, Jeffrey Hugo wrote:
> From: Fan Wu <wufan@codeaurora.org>
>
> Currently ENOMEM is returned when MHI ring is full. This error code is
> very misleading. Change to EAGAIN instead.
>
> Signed-off-by: Fan Wu <wufan@codeaurora.org>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> drivers/bus/mhi/core/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index 2c61dfd..a7811fb 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -1020,7 +1020,7 @@ static int mhi_queue(struct mhi_device *mhi_dev, struct mhi_buf_info *buf_info,
>
> ret = mhi_is_ring_full(mhi_cntrl, tre_ring);
> if (unlikely(ret)) {
> - ret = -ENOMEM;
> + ret = -EAGAIN;
> goto exit_unlock;
> }
>
> --
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-16 6:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-10 20:40 [PATCH v3 RESEND] bus: mhi: core: Return EAGAIN if MHI ring is full Jeffrey Hugo
2021-03-16 6:06 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox