From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D80C433E0 for ; Tue, 16 Mar 2021 09:55:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9FD16501C for ; Tue, 16 Mar 2021 09:54:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236396AbhCPJya (ORCPT ); Tue, 16 Mar 2021 05:54:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236387AbhCPJyH (ORCPT ); Tue, 16 Mar 2021 05:54:07 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B59E8C061756 for ; Tue, 16 Mar 2021 02:54:06 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id e10so10094961wro.12 for ; Tue, 16 Mar 2021 02:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YGgrY+UQz0yyfpooSgNBPEdgM8O/LnKtJy24CPMkDk4=; b=J4hILAogY9NYJY2rQsjTFJ2g2+IXUJYSXzpUiwEn66hrnbJWGmq7soF/FqfWTaUdw/ LEHH9dvCE9vu6aT7VtNMzP+C520L81vILqWt2s7WS/GtDw0qIHakVrJ80gQgOP6AfuHW Wj1h/CTcf4WANtB2q6vORaTHqiRoc0d+YP8+FcQ/hWOtjjCnAekHok0dL5FD03BFsn89 38OwQhPOSspZgy8XTqvaTa77XtrHmIX5A9SpqrYZ0yxMzM/Q104MW8VnhsouQq9Uh+we uBxO1kbmaMDRFTke4e2aOCfjMOFh/yzUSHT5Ffxkq50aFKrx5XggpFOyCiCaHD8nXU0Q 4ENw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YGgrY+UQz0yyfpooSgNBPEdgM8O/LnKtJy24CPMkDk4=; b=ORcB9XwbSwh/ziH0De0MijO/2K2KP06b1kSLSIKc09g+Cd0o1k8jUqTWv0BR9OCkK7 Fte2bDbtPObB5pEY9f6yzgqIEmzxeLwWtlVwPZrIKNpus9IfKCpIgzziksR5Z+vDdKng cNDWD5zaZMuaClGxeOi6Vv63jKKrkgvsUgXkS69BRLT8lBc7nD0N14TwDp57wON1aWMP 2QERn2s9uv6Kwj/Z1pklahTT10E4+ZqPzGDVkTo5QE5DC9zalpqWmFG1Ahl5GlzDb3al 8DJJd1wFCnY+kYoXz3xIOp31PLzUysi2c4vq3mA3jxJaJGSuG3RK5yLtBJIfnUDL2Z0B dMEw== X-Gm-Message-State: AOAM533BEBZlborVoYdqhRGJy/mSzmGY8b+SoZDnVXR8B+ajbN3vNU2C zQ8GQ9nZDGvTpZeqMJYYEv6ygg== X-Google-Smtp-Source: ABdhPJwOhbJWr/ukr1KQmlHy6R21fiPxX3G8mrMaAroA5wVQ4ry3KaakIEexLwXRpS1JXDhnOVLjgg== X-Received: by 2002:adf:eb0a:: with SMTP id s10mr4053098wrn.6.1615888445464; Tue, 16 Mar 2021 02:54:05 -0700 (PDT) Received: from dell ([91.110.221.243]) by smtp.gmail.com with ESMTPSA id m11sm21847679wrz.40.2021.03.16.02.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 02:54:05 -0700 (PDT) Date: Tue, 16 Mar 2021 09:54:03 +0000 From: Lee Jones To: "Jonas Mark (BT-FIR/ENG1-Grb)" Cc: Support Opensource , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "Adam.Thomson.Opensource@diasemi.com" , "stwiss.opensource@diasemi.com" , "marek.vasut@gmail.com" , "RUAN Tingquan (BT-FIR/ENG1-Zhu)" , "Streidl Hubert (BT-FIR/ENG1-Grb)" , Wolfram Sang Subject: Re: [PATCH v5] mfd: da9063: Support SMBus and I2C mode Message-ID: <20210316095403.GB701493@dell> References: <20210315160903.799426-1-mark.jonas@de.bosch.com> <20210316072143.GA701493@dell> <4dbc130e769547508be811e61a348255@de.bosch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4dbc130e769547508be811e61a348255@de.bosch.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Mar 2021, Jonas Mark (BT-FIR/ENG1-Grb) wrote: > Hi Lee, > > > Code looks good to me now, thanks. > > > > However, this doesn't look like it would pass checkpatch. > > > > Have you tried to build with W=1 and checkpatch? > > Yes, we used checkpatch.pl. > > $ ./scripts/checkpatch.pl 0001-mfd-da9063-Support-SMBus-and-I2C-mode.v5 > total: 0 errors, 0 warnings, 25 lines checked > > 0001-mfd-da9063-Support-SMBus-and-I2C-mode.v5 has no obvious style problems and is ready for submission. > > Using the option --strict we get a check hint that the broken line > of the regmap_clear_bits() is not aligned. We tried but were not > able to make the tool happy. This matches our experience with this > check hint and previous patches. Lining up the first char of the broken line with the open parenthesis will make checkpatch happy. It's easier if you configure your editor to always do this, rather than with strict tabs. > Also compiling Linux 5.10.14 with our patch and W=1 does not yield a warning. > > $ make W=1 > CALL scripts/checksyscalls.sh > CALL scripts/atomic/check-atomics.sh > CHK include/generated/compile.h > CC [M] drivers/mfd/da9063-i2c.o > LD [M] drivers/mfd/da9063.o > Kernel: arch/arm/boot/Image is ready > Kernel: arch/arm/boot/zImage is ready > MODPOST Module.symvers > LD [M] drivers/mfd/da9063.ko > > > > diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c index > > > 3781d0bb7786..e8a022e697c5 100644 > > > --- a/drivers/mfd/da9063-i2c.c > > > +++ b/drivers/mfd/da9063-i2c.c > > > @@ -442,6 +442,16 @@ static int da9063_i2c_probe(struct i2c_client *i2c, > > > return ret; > > > } > > > > > > + /* If SMBus is not available and only I2C is possible, enter I2C mode */ > > > + if (i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C)) { > > > + ret = regmap_clear_bits(da9063->regmap, > > DA9063_REG_CONFIG_J, > > > + DA9063_TWOWIRE_TO); > > > + if (ret < 0) { > > > + dev_err(da9063->dev, "Failed to set Two-Wire Bus > > Mode.\n"); > > > + return -EIO; > > > + } > > > + } > > > + > > > return da9063_device_init(da9063, i2c->irq); } > > > > > > diff --git a/include/linux/mfd/da9063/registers.h > > > b/include/linux/mfd/da9063/registers.h > > > index 1dbabf1b3cb8..6e0f66a2e727 100644 > > > --- a/include/linux/mfd/da9063/registers.h > > > +++ b/include/linux/mfd/da9063/registers.h > > > @@ -1037,6 +1037,9 @@ > > > #define DA9063_NONKEY_PIN_AUTODOWN 0x02 > > > #define DA9063_NONKEY_PIN_AUTOFLPRT 0x03 > > > > > > +/* DA9063_REG_CONFIG_J (addr=0x10F) */ > > > +#define DA9063_TWOWIRE_TO 0x40 > > > + > > > /* DA9063_REG_MON_REG_5 (addr=0x116) */ > > > #define DA9063_MON_A8_IDX_MASK 0x07 > > > #define DA9063_MON_A8_IDX_NONE 0x00 > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog