From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BA7C433E0 for ; Wed, 17 Mar 2021 01:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4148B64EFC for ; Wed, 17 Mar 2021 01:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbhCQBFx (ORCPT ); Tue, 16 Mar 2021 21:05:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:40950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232450AbhCQA7o (ORCPT ); Tue, 16 Mar 2021 20:59:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 76B7264F8F; Wed, 17 Mar 2021 00:59:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615942782; bh=Mezd5IsWSGg9kjEJcYPEX04+99/OxMusHKruQU9CGVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m8EwPx8/OzHVfgd7cN9agoD0VsG6sth906hrTO4f9o0MoScbR8mbC3KNzrxLHSXtn GJOps8o4juQyM5iQa3A5ipHd862NB+ntejZHE0poZsg1s/fecI3vZDjXcWj7u5PgAh 6/Md0HrvCZ1fBaXZhy9wDpMKnfJywiw1sFQ3xF5xRuq2Mz+meWTHNQBFSlgAEO/ZM/ 2kRd9Ivtrk+cuQHySrugtJgDK7OYG1z4vqwFL7rrwbVhxpPSHchg/+X5bUR6rA9jFD vtiL+Gh+NRBRyPrqXGbUxVZY2Lyzdfi7UkQymVIT5/w81UH+kFDeCUvttXBZdREJhr SbgUfJ2oITlqQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peter Zijlstra , Jakub Kicinski , "Ahmed S. Darwish" , "Erhard F." , Sasha Levin Subject: [PATCH AUTOSEL 4.14 17/21] u64_stats,lockdep: Fix u64_stats_init() vs lockdep Date: Tue, 16 Mar 2021 20:59:16 -0400 Message-Id: <20210317005920.726931-17-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210317005920.726931-1-sashal@kernel.org> References: <20210317005920.726931-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra [ Upstream commit d5b0e0677bfd5efd17c5bbb00156931f0d41cb85 ] Jakub reported that: static struct net_device *rtl8139_init_board(struct pci_dev *pdev) { ... u64_stats_init(&tp->rx_stats.syncp); u64_stats_init(&tp->tx_stats.syncp); ... } results in lockdep getting confused between the RX and TX stats lock. This is because u64_stats_init() is an inline calling seqcount_init(), which is a macro using a static variable to generate a lockdep class. By wrapping that in an inline, we negate the effect of the macro and fold the static key variable, hence the confusion. Fix by also making u64_stats_init() a macro for the case where it matters, leaving the other case an inline for argument validation etc. Reported-by: Jakub Kicinski Debugged-by: "Ahmed S. Darwish" Signed-off-by: Peter Zijlstra (Intel) Tested-by: "Erhard F." Link: https://lkml.kernel.org/r/YEXicy6+9MksdLZh@hirez.programming.kicks-ass.net Signed-off-by: Sasha Levin --- include/linux/u64_stats_sync.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux/u64_stats_sync.h b/include/linux/u64_stats_sync.h index 07ee0f84a46c..eb0a2532eb6f 100644 --- a/include/linux/u64_stats_sync.h +++ b/include/linux/u64_stats_sync.h @@ -69,12 +69,13 @@ struct u64_stats_sync { }; +#if BITS_PER_LONG == 32 && defined(CONFIG_SMP) +#define u64_stats_init(syncp) seqcount_init(&(syncp)->seq) +#else static inline void u64_stats_init(struct u64_stats_sync *syncp) { -#if BITS_PER_LONG == 32 && defined(CONFIG_SMP) - seqcount_init(&syncp->seq); -#endif } +#endif static inline void u64_stats_update_begin(struct u64_stats_sync *syncp) { -- 2.30.1