From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@redhat.com>,
Anna Schumaker <Anna.Schumaker@Netapp.com>,
Sasha Levin <sashal@kernel.org>,
linux-nfs@vger.kernel.org
Subject: [PATCH AUTOSEL 4.14 19/21] nfs: we don't support removing system.nfs4_acl
Date: Tue, 16 Mar 2021 20:59:18 -0400 [thread overview]
Message-ID: <20210317005920.726931-19-sashal@kernel.org> (raw)
In-Reply-To: <20210317005920.726931-1-sashal@kernel.org>
From: "J. Bruce Fields" <bfields@redhat.com>
[ Upstream commit 4f8be1f53bf615102d103c0509ffa9596f65b718 ]
The NFSv4 protocol doesn't have any notion of reomoving an attribute, so
removexattr(path,"system.nfs4_acl") doesn't make sense.
There's no documented return value. Arguably it could be EOPNOTSUPP but
I'm a little worried an application might take that to mean that we
don't support ACLs or xattrs. How about EINVAL?
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
fs/nfs/nfs4proc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index cbfea2c7d516..6d6c5123cbb6 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5255,6 +5255,9 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl
unsigned int npages = DIV_ROUND_UP(buflen, PAGE_SIZE);
int ret, i;
+ /* You can't remove system.nfs4_acl: */
+ if (buflen == 0)
+ return -EINVAL;
if (!nfs4_server_supports_acls(server))
return -EOPNOTSUPP;
if (npages > ARRAY_SIZE(pages))
--
2.30.1
next prev parent reply other threads:[~2021-03-17 1:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 0:59 [PATCH AUTOSEL 4.14 01/21] net: fec: ptp: avoid register access when ipg clock is disabled Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 02/21] powerpc/4xx: Fix build errors from mfdcr() Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 03/21] atm: eni: dont release is never initialized Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 04/21] atm: lanai: dont run lanai_dev_close if not open Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 05/21] Revert "r8152: adjust the settings about MAC clock speed down for RTL8153" Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 06/21] ixgbe: Fix memleak in ixgbe_configure_clsu32 Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 07/21] net: tehuti: fix error return code in bdx_probe() Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 08/21] sun/niu: fix wrong RXMAC_BC_FRM_CNT_COUNT count Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 09/21] gpiolib: acpi: Add missing IRQF_ONESHOT Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 10/21] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 11/21] NFS: Correct size calculation for create reply length Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 12/21] net: hisilicon: hns: fix error return code of hns_nic_clear_all_rx_fetch() Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 13/21] net: wan: fix error return code of uhdlc_init() Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 14/21] atm: uPD98402: fix incorrect allocation Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 15/21] atm: idt77252: fix null-ptr-dereference Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 16/21] sparc64: Fix opcode filtering in handling of no fault loads Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 17/21] u64_stats,lockdep: Fix u64_stats_init() vs lockdep Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 18/21] drm/radeon: fix AGP dependency Sasha Levin
2021-03-17 0:59 ` Sasha Levin [this message]
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 20/21] ia64: fix ia64_syscall_get_set_arguments() for break-based syscalls Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 21/21] ia64: fix ptrace(PTRACE_SYSCALL_INFO_EXIT) sign Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317005920.726931-19-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Anna.Schumaker@Netapp.com \
--cc=bfields@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox