From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Sergei Trofimovich <slyfox@gentoo.org>,
"Dmitry V . Levin" <ldv@altlinux.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Sasha Levin <sashal@kernel.org>,
linux-ia64@vger.kernel.org
Subject: [PATCH AUTOSEL 4.14 21/21] ia64: fix ptrace(PTRACE_SYSCALL_INFO_EXIT) sign
Date: Tue, 16 Mar 2021 20:59:20 -0400 [thread overview]
Message-ID: <20210317005920.726931-21-sashal@kernel.org> (raw)
In-Reply-To: <20210317005920.726931-1-sashal@kernel.org>
From: Sergei Trofimovich <slyfox@gentoo.org>
[ Upstream commit 61bf318eac2c13356f7bd1c6a05421ef504ccc8a ]
In https://bugs.gentoo.org/769614 Dmitry noticed that
`ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly.
The bug is in mismatch between get/set errors:
static inline long syscall_get_error(struct task_struct *task,
struct pt_regs *regs)
{
return regs->r10 == -1 ? regs->r8:0;
}
static inline long syscall_get_return_value(struct task_struct *task,
struct pt_regs *regs)
{
return regs->r8;
}
static inline void syscall_set_return_value(struct task_struct *task,
struct pt_regs *regs,
int error, long val)
{
if (error) {
/* error < 0, but ia64 uses > 0 return value */
regs->r8 = -error;
regs->r10 = -1;
} else {
regs->r8 = val;
regs->r10 = 0;
}
}
Tested on v5.10 on rx3600 machine (ia64 9040 CPU).
Link: https://lkml.kernel.org/r/20210221002554.333076-2-slyfox@gentoo.org
Link: https://bugs.gentoo.org/769614
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Reported-by: Dmitry V. Levin <ldv@altlinux.org>
Reviewed-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/ia64/include/asm/syscall.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/ia64/include/asm/syscall.h b/arch/ia64/include/asm/syscall.h
index 1d0b875fec44..ec909eec0b4c 100644
--- a/arch/ia64/include/asm/syscall.h
+++ b/arch/ia64/include/asm/syscall.h
@@ -35,7 +35,7 @@ static inline void syscall_rollback(struct task_struct *task,
static inline long syscall_get_error(struct task_struct *task,
struct pt_regs *regs)
{
- return regs->r10 == -1 ? regs->r8:0;
+ return regs->r10 == -1 ? -regs->r8:0;
}
static inline long syscall_get_return_value(struct task_struct *task,
--
2.30.1
prev parent reply other threads:[~2021-03-17 1:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 0:59 [PATCH AUTOSEL 4.14 01/21] net: fec: ptp: avoid register access when ipg clock is disabled Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 02/21] powerpc/4xx: Fix build errors from mfdcr() Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 03/21] atm: eni: dont release is never initialized Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 04/21] atm: lanai: dont run lanai_dev_close if not open Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 05/21] Revert "r8152: adjust the settings about MAC clock speed down for RTL8153" Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 06/21] ixgbe: Fix memleak in ixgbe_configure_clsu32 Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 07/21] net: tehuti: fix error return code in bdx_probe() Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 08/21] sun/niu: fix wrong RXMAC_BC_FRM_CNT_COUNT count Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 09/21] gpiolib: acpi: Add missing IRQF_ONESHOT Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 10/21] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 11/21] NFS: Correct size calculation for create reply length Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 12/21] net: hisilicon: hns: fix error return code of hns_nic_clear_all_rx_fetch() Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 13/21] net: wan: fix error return code of uhdlc_init() Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 14/21] atm: uPD98402: fix incorrect allocation Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 15/21] atm: idt77252: fix null-ptr-dereference Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 16/21] sparc64: Fix opcode filtering in handling of no fault loads Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 17/21] u64_stats,lockdep: Fix u64_stats_init() vs lockdep Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 18/21] drm/radeon: fix AGP dependency Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 19/21] nfs: we don't support removing system.nfs4_acl Sasha Levin
2021-03-17 0:59 ` [PATCH AUTOSEL 4.14 20/21] ia64: fix ia64_syscall_get_set_arguments() for break-based syscalls Sasha Levin
2021-03-17 0:59 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317005920.726931-21-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=ldv@altlinux.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=slyfox@gentoo.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox