Re: [PATCH v2] staging: comedi: cb_pcidas64: fix request_irq() warn

Ian Abbott
2021-03-16T10:32:12Z

On 15/03/2021 19:58, Tong Zhang wrote:
> request_irq() wont accept a name which contains slash so we need to
> repalce it with something else -- otherwise it will trigger a warning
> and the entry in /proc/irq/ will not be created
> since the .name might be used by userspace and we don't want to break
> userspace, so we are changing the parameters passed to request_irq()
>
> [ 1.565966] name 'pci-das6402/16'
> [ 1.566149] WARNING: CPU: 0 PID: 184 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0
> [ 1.568923] RIP: 0010:__xlate_proc_name+0x93/0xb0
> [ 1.574200] Call Trace:
> [ 1.574722] proc_mkdir+0x18/0x20
> [ 1.576629] request_threaded_irq+0xfe/0x160
> [ 1.576859] auto_attach+0x60a/0xc40 [cb_pcidas64]
>
> Suggested-by: Ian Abbott <abbotti@mev.co.uk>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> ---
> v2: revert changes to .name field so that we dont break userspace
>
> drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index fa987bb0e7cd..6d3ba399a7f0 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -4035,7 +4035,7 @@ static int auto_attach(struct comedi_device *dev,
> init_stc_registers(dev);
>
> retval = request_irq(pcidev->irq, handle_interrupt, IRQF_SHARED,
> - dev->board_name, dev);
> + "cb_pcidas64", dev);
> if (retval) {
> dev_dbg(dev->class_dev, "unable to allocate irq %u\n",
> pcidev->irq);
>

Looks good.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-