Re: [PATCH v5] rtc: rx6110: add ACPI bindings to I2C

Andy Shevchenko
2021-03-17T09:29:31Z

On Wed, Mar 17, 2021 at 9:56 AM Claudius Heine <ch@denx.de> wrote:
>
> From: Johannes Hahn <johannes-hahn@siemens.com>
>
> This allows the RX6110 driver to be automatically assigned to the right
> device on the I2C bus.

Thanks for an update!

> Signed-off-by: Johannes Hahn <johannes-hahn@siemens.com>
> Co-developed-by: Claudius Heine <ch@denx.de>
> Signed-off-by: Claudius Heine <ch@denx.de>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Reported-by: kernel test robot <lkp@intel.com>

This is usually for patches that do fix found problems, here it's a
completely new item and the report was done in the middle of the
development. That said, you may give credit to LKP by just mentioning
it in the comments section (after the cutter '---' line). I'll leave
this to Alexandre and Alessandro to decide if you need a resend or
they may remove it when applying. (In my opinion resend is not needed
right now)

> ---
> drivers/rtc/rtc-rx6110.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c
> index 79161d4c6ce4..f4d425002f7f 100644
> --- a/drivers/rtc/rtc-rx6110.c
> +++ b/drivers/rtc/rtc-rx6110.c
> @@ -447,6 +447,12 @@ static int rx6110_i2c_probe(struct i2c_client *client,
> return rx6110_probe(rx6110, &client->dev);
> }
>
> +static const struct acpi_device_id rx6110_i2c_acpi_match[] = {
> + { "SECC6110" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match);
> +
> static const struct i2c_device_id rx6110_i2c_id[] = {
> { "rx6110", 0 },
> { }
> @@ -456,6 +462,7 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id);
> static struct i2c_driver rx6110_i2c_driver = {
> .driver = {
> .name = RX6110_DRIVER_NAME,
> + .acpi_match_table = rx6110_i2c_acpi_match,
> },
> .probe = rx6110_i2c_probe,
> .id_table = rx6110_i2c_id,
>
> base-commit: 1df27313f50a57497c1faeb6a6ae4ca939c85a7d
> --
> 2.30.1
>

--
With Best Regards,
Andy Shevchenko