From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E0AC433E0 for ; Wed, 17 Mar 2021 10:07:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA76A64F6A for ; Wed, 17 Mar 2021 10:07:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230478AbhCQKHL (ORCPT ); Wed, 17 Mar 2021 06:07:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:35800 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230063AbhCQKGl (ORCPT ); Wed, 17 Mar 2021 06:06:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3C410AC1F; Wed, 17 Mar 2021 10:06:40 +0000 (UTC) Date: Wed, 17 Mar 2021 11:06:37 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Vlastimil Babka , Michal Hocko , Muchun Song , Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Anshuman Khandual Subject: Re: [PATCH v4 0/4] Make alloc_contig_range handle Hugetlb pages Message-ID: <20210317100637.GB16479@linux> References: <20210310150853.13541-1-osalvador@suse.de> <01d2ee6a-f0aa-4580-b1f4-f0e8a2ded4f8@redhat.com> <20210317100518.GA16479@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210317100518.GA16479@linux> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 17, 2021 at 11:05:23AM +0100, Oscar Salvador wrote: > From e97175b7d4970cbdcbafcf8c398f72a571e817b0 Mon Sep 17 00:00:00 2001 > From: Oscar Salvador > Date: Thu, 18 Mar 2021 05:03:18 +0100 > Subject: [PATCH] mm,page_alloc: Drop unnecesary checks from > pfn_range_valid_contig > > pfn_range_valid_contig() bails out when it finds an in-use page or a > hugetlb page, among other things. > We can drop the in-use page check since __alloc_contig_pages can migrate > away those pages, and the hugetlb page check can go too since > isolate_migratepages_range is now capable of dealing with hugetlb pages. > > Signed-off-by: Oscar Salvador Of course, missing a Suggested-by: David Hildenbrand -- Oscar Salvador SUSE L3