From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
He Ying <heying24@huawei.com>,
frederic@kernel.org, paulmck@kernel.org, clg@kaod.org,
qais.yousef@arm.com, johnny.chenyi@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] smp: kernel/panic.c - silence warnings
Date: Wed, 17 Mar 2021 21:09:22 +0100 [thread overview]
Message-ID: <20210317200922.GC3830960@gmail.com> (raw)
In-Reply-To: <YFI+YMo7zml+spKc@hirez.programming.kicks-ass.net>
* Peter Zijlstra <peterz@infradead.org> wrote:
> Now, the C people figured that distinction was useless and allowed
> sloppiness. But I still think there's merrit to that. And as
> mentioned earlier, it is consistent with variable declarations.
Fully agreed, and my other point was that it's also consistent with
the other existing externs were used *in the same header file*
already.
I.e. there's nothing more sloppy than mixing different styles within
the same header. Checkpatch needs to be fixed or ignored here.
Thanks,
Ingo
next prev parent reply other threads:[~2021-03-17 20:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 8:41 [PATCH v2] smp: kernel/panic.c - silence warnings He Ying
2021-03-17 9:49 ` Ingo Molnar
2021-03-17 11:00 ` Christophe Leroy
2021-03-17 12:23 ` Peter Zijlstra
2021-03-17 17:17 ` Christophe Leroy
2021-03-17 17:37 ` Peter Zijlstra
2021-03-17 20:09 ` Ingo Molnar [this message]
2021-03-18 2:56 ` heying (H)
2021-03-18 6:11 ` Christophe Leroy
2021-03-18 6:04 ` Christophe Leroy
2021-03-18 5:53 ` Christophe Leroy
2021-03-19 1:39 ` heying (H)
2021-03-19 6:58 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317200922.GC3830960@gmail.com \
--to=mingo@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=clg@kaod.org \
--cc=frederic@kernel.org \
--cc=heying24@huawei.com \
--cc=johnny.chenyi@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox