From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: staging: rtl8723bs: prefer ftrace
Date: Thu, 18 Mar 2021 10:14:15 +0100 [thread overview]
Message-ID: <20210318091415.GA3683@agape.jhs> (raw)
Hi,
some suggestions before diving in a new task.
The following checkpatch issue:
--
WARNING: Unnecessary ftrace-like logging - prefer using ftrace
#559: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:559:
+ DBG_871X("%s\n", __func__);
simply says to remove the line, due to the existence of the more
appealing ftrace facility, right?
@@ -556,8 +554,6 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)
/* set intf_tag to if1 */
/* psta->intf_tag = 0; */
- DBG_871X("%s\n", __func__);
-
/* psta->mac_id = psta->aid+4; */
/* psta->mac_id = psta->aid+1;//alloc macid when call rtw_alloc_stainfo(), */
/* release macid when call rtw_free_stainfo() */
thank you,
fabio
next reply other threads:[~2021-03-18 9:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 9:14 Fabio Aiuto [this message]
2021-03-18 9:23 ` staging: rtl8723bs: prefer ftrace Greg KH
2021-03-18 15:25 ` [PATCH 00/15] remove unnecessary logging Fabio Aiuto
2021-03-18 15:25 ` [PATCH 01/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_ap.c Fabio Aiuto
2021-03-18 15:25 ` [PATCH 02/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme.c Fabio Aiuto
2021-03-18 15:25 ` [PATCH 03/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme_ext.c Fabio Aiuto
2021-03-18 15:25 ` [PATCH 04/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_pwrctrl.c Fabio Aiuto
2021-03-18 15:26 ` [PATCH 05/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_wlan_util.c Fabio Aiuto
2021-03-18 15:26 ` [PATCH 06/15] staging: rtl8723bs: remove unnecessary logging in hal/HalBtcOutSrc.h Fabio Aiuto
2021-03-18 15:26 ` [PATCH 07/15] staging: rtl8723bs: remove unnecessary logging in hal/hal_com_phycfg.c Fabio Aiuto
2021-03-18 15:26 ` [PATCH 08/15] staging: rtl8723bs: remove unnecessary logging in hal/odm.c Fabio Aiuto
2021-03-18 15:26 ` [PATCH 09/15] staging: rtl8723bs: remove unnecessary logging in hal/odm_debug.h Fabio Aiuto
2021-03-18 15:26 ` [PATCH 10/15] staging: rtl8723bs: remove unnecessary logging in hal/rtl8723b_cmd.c Fabio Aiuto
2021-03-18 15:26 ` [PATCH 11/15] staging: rtl8723bs: remove unnecessary logging in hal/rtl8723b_hal_init.c Fabio Aiuto
2021-03-18 15:26 ` [PATCH 12/15] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_cfg80211.c Fabio Aiuto
2021-03-19 9:21 ` Dan Carpenter
2021-03-19 10:09 ` [PATCH v2] " Fabio Aiuto
2021-03-18 15:26 ` [PATCH 13/15] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_linux.c Fabio Aiuto
2021-03-18 15:26 ` [PATCH 14/15] staging: rtl8723bs: remove unnecessary logging in os_dep/os_intfs.c Fabio Aiuto
2021-03-18 15:26 ` [PATCH 15/15] staging: rtl8723bs: remove unnecessary logging in os_dep/wifi_regd.c Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318091415.GA3683@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox