From: taehyun cho <taehyun.cho@samsung.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: balbi@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: remove 'pm_runtime_set_active' in resume callback
Date: Thu, 18 Mar 2021 21:42:12 +0900 [thread overview]
Message-ID: <20210318124212.GC138912@rack03> (raw)
In-Reply-To: <20210317151159.GA488655@rowland.harvard.edu>
[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]
On Wed, Mar 17, 2021 at 11:11:59AM -0400, Alan Stern wrote:
> On Wed, Mar 17, 2021 at 05:25:20PM +0900, taehyun cho wrote:
> > On Mon, Mar 15, 2021 at 10:13:35AM -0400, Alan Stern wrote:
> > > On Mon, Mar 15, 2021 at 04:43:17PM +0900, taehyun cho wrote:
> > > > 'pm_runtime_set_active' sets a flag to describe rumtime status.
> > > > This flag is automatically set in pm_runtime_get_sync/put_sync API.
> > > > 'pm_runtime_set_active' checks the runtime status of parent device.
> > > > As a result, the below error message is printed.
> > > > dwc3 11110000.dwc3: runtime PM trying to activate child device
> > > > 11110000.dwc3 but parent (11110000.usb) is not active.
> > >
> > > This is very suspicious. That error message indicates a real error is
> > > present; removing these pm_runtime_set_active calls won't fix the error.
> > >
> > > You need to determine why the parent platform device 11110000.usb isn't
> > > active when the dwc3 probe and resume routines are called. It seems
> > > likely that there is a bug in the platform device's driver.
> > >
> > > Alan Stern
> > >
> >
> > Alan,
> >
> > Thanks to your comments, I checked our platform device driver and found
> > the problem. Our parent platform device didn't set active in resume
> > callback. This made a problem.
>
> Ah, good. Does the platform driver set the active flag in its probe
> routine?
>
PM resume callback function in our platform driver had a bug.
Resume callback function doesn't set active flag in 'pm_runtime_suspended' state.
This is a obvious bug. We are rebuilding our platform device driver. This bug
looks inserted while rebuilding a driver.
Thanks.
Taehyun Cho
> > Thank you for the help and sorry for
> > disturbing you.
>
> No problem at all.
>
> Alan Stern
>
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2021-03-18 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210315074223epcas2p11ddf190ec730f8629c1310117135f813@epcas2p1.samsung.com>
2021-03-15 7:43 ` [PATCH] usb: dwc3: remove 'pm_runtime_set_active' in resume callback taehyun cho
2021-03-15 14:13 ` Alan Stern
2021-03-16 12:16 ` taehyun cho
2021-03-17 8:25 ` taehyun cho
2021-03-17 15:11 ` Alan Stern
2021-03-18 12:42 ` taehyun cho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318124212.GC138912@rack03 \
--to=taehyun.cho@samsung.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox