From: Baoquan He <bhe@redhat.com>
To: menglong8.dong@gmail.com
Cc: dyoung@redhat.com, vgoyal@redhat.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, tiantao6@hisilicon.com,
Zhang Yunkai <zhang.yunkai@zte.com.cn>
Subject: Re: [PATCH] crash_dump: remove duplicate include in crash_dump.h
Date: Fri, 19 Mar 2021 20:38:45 +0800 [thread overview]
Message-ID: <20210319123845.GA2289@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20210313103521.364854-1-zhang.yunkai@zte.com.cn>
On 03/13/21 at 02:35am, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
>
> 'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
> It is also included in the 8th line.
Tian Tao posted one to address the same issue, his log is better. Please
update with below to repost.
linux/pgtable.h is included more than once, Remove the one that isn't
necessary.
>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> ---
> include/linux/crash_dump.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index a5192b718dbe..6bd8a33cb740 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
> #include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
> #ifdef CONFIG_CRASH_DUMP
> #define ELFCORE_ADDR_MAX (-1ULL)
> #define ELFCORE_ADDR_ERR (-2ULL)
> --
> 2.25.1
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
next prev parent reply other threads:[~2021-03-19 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 10:35 [PATCH] crash_dump: remove duplicate include in crash_dump.h menglong8.dong
2021-03-19 12:38 ` Baoquan He [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-20 1:23 cgel.zte
2021-10-20 1:53 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319123845.GA2289@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=tiantao6@hisilicon.com \
--cc=vgoyal@redhat.com \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox