* [PATCH] crash_dump: remove duplicate include in crash_dump.h
@ 2021-03-13 10:35 menglong8.dong
2021-03-19 12:38 ` Baoquan He
0 siblings, 1 reply; 4+ messages in thread
From: menglong8.dong @ 2021-03-13 10:35 UTC (permalink / raw)
To: dyoung; +Cc: bhe, vgoyal, kexec, linux-kernel, Zhang Yunkai
From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
It is also included in the 8th line.
Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
include/linux/crash_dump.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index a5192b718dbe..6bd8a33cb740 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -8,8 +8,6 @@
#include <linux/pgtable.h>
#include <uapi/linux/vmcore.h>
-#include <linux/pgtable.h> /* for pgprot_t */
-
#ifdef CONFIG_CRASH_DUMP
#define ELFCORE_ADDR_MAX (-1ULL)
#define ELFCORE_ADDR_ERR (-2ULL)
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crash_dump: remove duplicate include in crash_dump.h
2021-03-13 10:35 [PATCH] crash_dump: remove duplicate include in crash_dump.h menglong8.dong
@ 2021-03-19 12:38 ` Baoquan He
0 siblings, 0 replies; 4+ messages in thread
From: Baoquan He @ 2021-03-19 12:38 UTC (permalink / raw)
To: menglong8.dong
Cc: dyoung, vgoyal, kexec, linux-kernel, tiantao6, Zhang Yunkai
On 03/13/21 at 02:35am, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
>
> 'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
> It is also included in the 8th line.
Tian Tao posted one to address the same issue, his log is better. Please
update with below to repost.
linux/pgtable.h is included more than once, Remove the one that isn't
necessary.
>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> ---
> include/linux/crash_dump.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index a5192b718dbe..6bd8a33cb740 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
> #include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
> #ifdef CONFIG_CRASH_DUMP
> #define ELFCORE_ADDR_MAX (-1ULL)
> #define ELFCORE_ADDR_ERR (-2ULL)
> --
> 2.25.1
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] crash_dump: remove duplicate include in crash_dump.h
@ 2021-10-20 1:23 cgel.zte
2021-10-20 1:53 ` Baoquan He
0 siblings, 1 reply; 4+ messages in thread
From: cgel.zte @ 2021-10-20 1:23 UTC (permalink / raw)
To: dyoung; +Cc: bhe, vgoyal, kexec, linux-kernel, Ye Guojin, Zeal Robot
From: Ye Guojin <ye.guojin@zte.com.cn>
'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
it's also included at line 8.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
---
include/linux/crash_dump.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index 0c547d866f1e..b7b255b23b99 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -8,8 +8,6 @@
#include <linux/pgtable.h>
#include <uapi/linux/vmcore.h>
-#include <linux/pgtable.h> /* for pgprot_t */
-
/* For IS_ENABLED(CONFIG_CRASH_DUMP) */
#define ELFCORE_ADDR_MAX (-1ULL)
#define ELFCORE_ADDR_ERR (-2ULL)
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crash_dump: remove duplicate include in crash_dump.h
2021-10-20 1:23 cgel.zte
@ 2021-10-20 1:53 ` Baoquan He
0 siblings, 0 replies; 4+ messages in thread
From: Baoquan He @ 2021-10-20 1:53 UTC (permalink / raw)
To: cgel.zte; +Cc: dyoung, vgoyal, kexec, linux-kernel, Ye Guojin, Zeal Robot, rppt
On 10/20/21 at 01:23am, cgel.zte@gmail.com wrote:
> From: Ye Guojin <ye.guojin@zte.com.cn>
>
> 'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
> it's also included at line 8.
OK, in below commit the including order is adjusted, but the old one was
not removed.
commit 65fddcfca8ad("mm: reorder includes after introduction of linux/pgtable.h")
Could you rephrase the commit log? , the below sentences is for your reference.
============
In crash_dump.h, header file linux/pgtable.h is included twice. This
duplication was introduced in commit 65fddcfca8ad("mm: reorder includes
after introduction of linux/pgtable.h") where the order of include is
adjusted, while the old one was not removed.
Clean it up here.
============
Thanks for fixing this. when you finish polishing the patch log, please
feel free to add:
Acked-by: Baoquan He <bhe@redhat.com>
Thanks
Baoquan
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
> ---
> include/linux/crash_dump.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index 0c547d866f1e..b7b255b23b99 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
> #include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
> /* For IS_ENABLED(CONFIG_CRASH_DUMP) */
> #define ELFCORE_ADDR_MAX (-1ULL)
> #define ELFCORE_ADDR_ERR (-2ULL)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-20 1:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-13 10:35 [PATCH] crash_dump: remove duplicate include in crash_dump.h menglong8.dong
2021-03-19 12:38 ` Baoquan He
-- strict thread matches above, loose matches on Subject: below --
2021-10-20 1:23 cgel.zte
2021-10-20 1:53 ` Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox