From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE15C433E1 for ; Fri, 19 Mar 2021 17:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9658661982 for ; Fri, 19 Mar 2021 17:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230042AbhCSRuD (ORCPT ); Fri, 19 Mar 2021 13:50:03 -0400 Received: from outbound-smtp46.blacknight.com ([46.22.136.58]:45015 "EHLO outbound-smtp46.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230028AbhCSRt3 (ORCPT ); Fri, 19 Mar 2021 13:49:29 -0400 Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp46.blacknight.com (Postfix) with ESMTPS id BCD1FFB8E0 for ; Fri, 19 Mar 2021 17:49:27 +0000 (GMT) Received: (qmail 11366 invoked from network); 19 Mar 2021 17:49:27 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.22.4]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 19 Mar 2021 17:49:27 -0000 Date: Fri, 19 Mar 2021 17:49:26 +0000 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Chuck Lever , Jesper Dangaard Brouer , Christoph Hellwig , Alexander Duyck , Matthew Wilcox , LKML , Linux-Net , Linux-MM , Linux-NFS Subject: Re: [PATCH 1/7] mm/page_alloc: Move gfp_allowed_mask enforcement to prepare_alloc_pages Message-ID: <20210319174926.GC3697@techsingularity.net> References: <20210312154331.32229-1-mgorman@techsingularity.net> <20210312154331.32229-2-mgorman@techsingularity.net> <2b5b3bea-c247-0564-f2d4-1dad28f176ed@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <2b5b3bea-c247-0564-f2d4-1dad28f176ed@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 19, 2021 at 05:11:39PM +0100, Vlastimil Babka wrote: > On 3/12/21 4:43 PM, Mel Gorman wrote: > > __alloc_pages updates GFP flags to enforce what flags are allowed > > during a global context such as booting or suspend. This patch moves the > > enforcement from __alloc_pages to prepare_alloc_pages so the code can be > > shared between the single page allocator and a new bulk page allocator. > > > > When moving, it is obvious that __alloc_pages() and __alloc_pages > > use different names for the same variable. This is an unnecessary > > complication so rename gfp_mask to gfp in prepare_alloc_pages() so the > > name is consistent. > > > > No functional change. > > Hm, I have some doubts. > And you were right, I'll drop the patch and apply the same mask to the bulk allocator. -- Mel Gorman SUSE Labs