From: Christoph Hellwig <hch@lst.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
"open list:SWIOTLB SUBSYSTEM" <iommu@lists.linux-foundation.org>
Subject: Re: [PATCH v2] swiotlb: Make SWIOTLB_NO_FORCE perform no allocation
Date: Mon, 22 Mar 2021 08:46:27 +0100 [thread overview]
Message-ID: <20210322074627.GA4252@lst.de> (raw)
In-Reply-To: <20210321033740.312500-1-f.fainelli@gmail.com>
On Sat, Mar 20, 2021 at 08:37:40PM -0700, Florian Fainelli wrote:
> - if (!strcmp(str, "force")) {
> + if (!strcmp(str, "force"))
> swiotlb_force = SWIOTLB_FORCE;
> - } else if (!strcmp(str, "noforce")) {
> + else if (!strcmp(str, "noforce"))
> swiotlb_force = SWIOTLB_NO_FORCE;
> - default_nslabs = 1;
> - }
>
> return 0;
> }
> @@ -211,6 +209,9 @@ swiotlb_init(int verbose)
> size_t bytes = PAGE_ALIGN(default_nslabs << IO_TLB_SHIFT);
> void *tlb;
>
> + if (swiotlb_force == SWIOTLB_NO_FORCE)
> + return;
We'll also need this in the other callers of swiotlb_init_with_tbl
and swiotlb_late_init_with_tbl.
I actually had a plan to mostly kill them, but that can better
way until more support for multiple io_tlb structures is merged.
next prev parent reply other threads:[~2021-03-22 7:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 19:18 [PATCH] swiotlb: Add swiotlb=off to disable SWIOTLB Florian Fainelli
2021-03-18 19:22 ` Florian Fainelli
2021-03-18 19:34 ` Robin Murphy
2021-03-18 19:43 ` Florian Fainelli
2021-03-18 19:53 ` Robin Murphy
2021-03-18 21:31 ` Florian Fainelli
2021-03-18 23:35 ` Robin Murphy
2021-03-19 0:48 ` Florian Fainelli
2021-03-19 2:34 ` Konrad Rzeszutek Wilk
2021-03-19 4:00 ` [PATCH] swiotlb: Make SWIOTLB_NO_FORCE perform no allocation Florian Fainelli
2021-03-19 5:01 ` Konrad Rzeszutek Wilk
2021-03-21 3:37 ` [PATCH v2] " Florian Fainelli
2021-03-22 7:46 ` Christoph Hellwig [this message]
2021-03-23 1:53 ` [PATCH v3] " Florian Fainelli
2021-03-24 8:42 ` Christoph Hellwig
2021-04-09 3:13 ` Florian Fainelli
2021-04-09 19:32 ` Konrad Rzeszutek Wilk
2021-04-09 20:33 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322074627.GA4252@lst.de \
--to=hch@lst.de \
--cc=f.fainelli@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox