Re: [PATCH v7 3/3] mtd: rawnand: Add support for secure regions in NAND memory

Manivannan Sadhasivam
2021-03-22T09:41:57Z

On Fri, Mar 19, 2021 at 05:56:59PM +0100, Boris Brezillon wrote:
> On Fri, 19 Mar 2021 20:30:10 +0530
> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
>
> > @@ -2737,6 +2783,11 @@ static int nand_read_page_swecc(struct nand_chip *chip, uint8_t *buf,
> > uint8_t *ecc_code = chip->ecc.code_buf;
> > unsigned int max_bitflips = 0;
> >
> > + /* Check if the region is secured */
> > + ret = nand_check_secure_region(chip, ((loff_t)page << chip->page_shift), 0);
> > + if (ret)
> > + return ret;
> > +
>
> I'm lost. Why do you need to do that here if it's already done in
> nand_do_read_{ops,oob}()?
>

I think that's a mistake. Will remove it.

Thanks,
Mani

> > chip->ecc.read_page_raw(chip, buf, 1, page);
> >
> > for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize)