Re: [PATCH net-next] [v2] misdn: avoid -Wempty-body warning

Leon Romanovsky
2021-03-22T13:59:27Z

On Mon, Mar 22, 2021 at 01:14:47PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> gcc warns about a pointless condition:
>
> drivers/isdn/hardware/mISDN/hfcmulti.c: In function 'hfcmulti_interrupt':
> drivers/isdn/hardware/mISDN/hfcmulti.c:2752:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 2752 | ; /* external IRQ */
>
> As the check has no effect, just remove it.
>
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: remove the line instead of adding {}
> ---
> drivers/isdn/hardware/mISDN/hfcmulti.c | 2 --
> 1 file changed, 2 deletions(-)
>

Thanks, interesting when we will delete whole drivers/isdn :)

Reviewed-by: Leon Romanovsky <leonro@nvidia.com>