From: Lee Jones <lee.jones@linaro.org>
To: 'Wei Yongjun <weiyongjun1@huawei.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Cristian Ciocaltea <cristian.ciocaltea@gmail.com>,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static
Date: Mon, 22 Mar 2021 14:52:26 +0000 [thread overview]
Message-ID: <20210322145226.GX2916463@dell> (raw)
In-Reply-To: <20210311131507.1902008-1-weiyongjun1@huawei.com>
On Thu, 11 Mar 2021, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/mfd/atc260x-i2c.c:45:27: warning:
> symbol 'atc260x_i2c_of_match' was not declared. Should it be static?
>
> This symbol is not used outside of atc260x-i2c.c, so this
> commit marks it static.
>
> Fixes: f7cb7fe34db9 ("mfd: Add MFD driver for ATC260x PMICs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/mfd/atc260x-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-03-22 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 13:15 [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static 'Wei Yongjun
2021-03-11 17:12 ` Cristian Ciocaltea
2021-03-22 14:52 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322145226.GX2916463@dell \
--to=lee.jones@linaro.org \
--cc=cristian.ciocaltea@gmail.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox