* [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static
@ 2021-03-11 13:15 'Wei Yongjun
2021-03-11 17:12 ` Cristian Ciocaltea
2021-03-22 14:52 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: 'Wei Yongjun @ 2021-03-11 13:15 UTC (permalink / raw)
To: weiyongjun1, Manivannan Sadhasivam, Cristian Ciocaltea, Lee Jones
Cc: linux-actions, linux-kernel, kernel-janitors, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
The sparse tool complains as follows:
drivers/mfd/atc260x-i2c.c:45:27: warning:
symbol 'atc260x_i2c_of_match' was not declared. Should it be static?
This symbol is not used outside of atc260x-i2c.c, so this
commit marks it static.
Fixes: f7cb7fe34db9 ("mfd: Add MFD driver for ATC260x PMICs")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mfd/atc260x-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/atc260x-i2c.c b/drivers/mfd/atc260x-i2c.c
index 362005703367..5855efd09efc 100644
--- a/drivers/mfd/atc260x-i2c.c
+++ b/drivers/mfd/atc260x-i2c.c
@@ -42,7 +42,7 @@ static int atc260x_i2c_probe(struct i2c_client *client,
return atc260x_device_probe(atc260x);
}
-const struct of_device_id atc260x_i2c_of_match[] = {
+static const struct of_device_id atc260x_i2c_of_match[] = {
{ .compatible = "actions,atc2603c", .data = (void *)ATC2603C },
{ .compatible = "actions,atc2609a", .data = (void *)ATC2609A },
{ }
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static
2021-03-11 13:15 [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static 'Wei Yongjun
@ 2021-03-11 17:12 ` Cristian Ciocaltea
2021-03-22 14:52 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Cristian Ciocaltea @ 2021-03-11 17:12 UTC (permalink / raw)
To: 'Wei Yongjun
Cc: Manivannan Sadhasivam, Lee Jones, linux-actions, linux-kernel,
kernel-janitors, Hulk Robot
On Thu, Mar 11, 2021 at 01:15:07PM +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/mfd/atc260x-i2c.c:45:27: warning:
> symbol 'atc260x_i2c_of_match' was not declared. Should it be static?
>
> This symbol is not used outside of atc260x-i2c.c, so this
> commit marks it static.
>
> Fixes: f7cb7fe34db9 ("mfd: Add MFD driver for ATC260x PMICs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
Thanks,
Cristi
> ---
> drivers/mfd/atc260x-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/atc260x-i2c.c b/drivers/mfd/atc260x-i2c.c
> index 362005703367..5855efd09efc 100644
> --- a/drivers/mfd/atc260x-i2c.c
> +++ b/drivers/mfd/atc260x-i2c.c
> @@ -42,7 +42,7 @@ static int atc260x_i2c_probe(struct i2c_client *client,
> return atc260x_device_probe(atc260x);
> }
>
> -const struct of_device_id atc260x_i2c_of_match[] = {
> +static const struct of_device_id atc260x_i2c_of_match[] = {
> { .compatible = "actions,atc2603c", .data = (void *)ATC2603C },
> { .compatible = "actions,atc2609a", .data = (void *)ATC2609A },
> { }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static
2021-03-11 13:15 [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static 'Wei Yongjun
2021-03-11 17:12 ` Cristian Ciocaltea
@ 2021-03-22 14:52 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2021-03-22 14:52 UTC (permalink / raw)
To: 'Wei Yongjun
Cc: Manivannan Sadhasivam, Cristian Ciocaltea, linux-actions,
linux-kernel, kernel-janitors, Hulk Robot
On Thu, 11 Mar 2021, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/mfd/atc260x-i2c.c:45:27: warning:
> symbol 'atc260x_i2c_of_match' was not declared. Should it be static?
>
> This symbol is not used outside of atc260x-i2c.c, so this
> commit marks it static.
>
> Fixes: f7cb7fe34db9 ("mfd: Add MFD driver for ATC260x PMICs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/mfd/atc260x-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-22 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-11 13:15 [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static 'Wei Yongjun
2021-03-11 17:12 ` Cristian Ciocaltea
2021-03-22 14:52 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox