Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

[Lee Jones <lee.jones@linaro.org>]

On Thu, 11 Mar 2021, Mark Brown wrote:

> On Wed, Mar 10, 2021 at 09:48:21AM +0000, Lee Jones wrote:
> 
> > Could you take a look at this for me please:
> 
> > > +static int regmap_ignore_write(void *context,
> > > +			       unsigned int reg, unsigned int val)
> > > +
> > > +{
> > > +	struct regmap *regmap = context;
> > > +
> > > +	regmap_write(regmap, reg, val);
> > > +
> > > +	return 0;
> > > +}
> 
> If there were more users it'd be better to have this in the core so that
> problems we can detect like cache stuff if that's used but if it's just
> one broken device it's probably not worth it, this seems like something
> you'd have to try to end up with and which is going to cause timeout
> problems with a lot of I2C controllers which would tank performance
> enough that people would notice.

So Yoda, is this to go into the core, or stay where it is?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog