Re: [PATCH 07/23] mm: Introduce zap_details.zap_flags

Matthew Wilcox
2021-03-23T02:12:41Z

On Mon, Mar 22, 2021 at 08:48:56PM -0400, Peter Xu wrote:
> +/* Whether to check page->mapping when zapping */
> +#define ZAP_FLAG_CHECK_MAPPING BIT(0)
> +
> /*
> * Parameter block passed down to zap_pte_range in exceptional cases.
> */
> struct zap_details {
> - struct address_space *check_mapping; /* Check page->mapping if set */
> + struct address_space *zap_mapping; /* Check page->mapping if set */

Now the comment is wrong. It used to mean "If this is NULL, zap pages
with any mapping", but now it's always set, and the decision about whether
to check the mapping is in the flag.

Honestly, I'd remove the comments from both these members. They don't add
anything to understandability now.

> + unsigned long zap_flags; /* Special flags for zapping */
> };