From: Guenter Roeck <linux@roeck-us.net>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
Date: Wed, 24 Mar 2021 21:57:09 -0700 [thread overview]
Message-ID: <20210325045709.GA115263@roeck-us.net> (raw)
On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
> If build kernel without "O=dir", below error will be seen:
>
> In file included from drivers/tee/optee/optee_trace.h:67,
> from drivers/tee/optee/call.c:18:
> ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> | ^
> compilation terminated.
>
> Fix it by adding below line to Makefile:
> CFLAGS_call.o := -I$(src)
>
> Tested with and without "O=dir", both can build successfully.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/tee/optee/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile
> index 56263ae3b1d7..3aa33ea9e6a6 100644
> --- a/drivers/tee/optee/Makefile
> +++ b/drivers/tee/optee/Makefile
> @@ -6,3 +6,6 @@ optee-objs += rpc.o
> optee-objs += supp.o
> optee-objs += shm_pool.o
> optee-objs += device.o
> +
> +# for tracing framework to find optee_trace.h
> +CFLAGS_call.o := -I$(src)
> --
> 2.31.0
>
next reply other threads:[~2021-03-25 4:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 4:57 Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-25 4:06 [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature Jisheng Zhang
2021-03-30 6:53 ` Heiko Thiery
2021-03-30 8:26 ` Jens Wiklander
2021-04-06 10:38 ` Heiko Thiery
2021-04-06 12:30 ` Jens Wiklander
2021-04-06 14:20 ` Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325045709.GA115263@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Jisheng.Zhang@synaptics.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox