From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kael_w@yeah.net
Subject: Re: [PATCH] drivers: staging: _adapter is declared twice
Date: Thu, 25 Mar 2021 10:31:54 +0300 [thread overview]
Message-ID: <20210325073154.GU1717@kadam> (raw)
In-Reply-To: <20210325062843.852204-1-wanjiabing@vivo.com>
On Thu, Mar 25, 2021 at 02:28:40PM +0800, Wan Jiabing wrote:
> struct _adapter has been declared at 23rd line.
> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/staging/rtl8712/drv_types.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 0c4325073c63..976d19cdcf87 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -36,7 +36,6 @@ enum _NIC_VERSION {
> RTL8716_NIC
> };
>
> -struct _adapter;
>
> struct qos_priv {
You need to delete the blank line after it as well to avoid the
checkpatch warning about two blank lines in a row.
regards,
dan carpenter
prev parent reply other threads:[~2021-03-25 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 6:28 [PATCH] drivers: staging: _adapter is declared twice Wan Jiabing
2021-03-25 7:31 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325073154.GU1717@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox