Re: [PATCH 2/9] mm/page_alloc: Add a bulk page allocator

Matthew Wilcox
2021-03-25T12:08:08Z

On Thu, Mar 25, 2021 at 11:42:21AM +0000, Mel Gorman wrote:
> +int __alloc_pages_bulk(gfp_t gfp, int preferred_nid,
> + nodemask_t *nodemask, int nr_pages,
> + struct list_head *list);
> +
> +/* Bulk allocate order-0 pages */
> +static inline unsigned long
> +alloc_pages_bulk(gfp_t gfp, unsigned long nr_pages, struct list_head *list)
> +{
> + return __alloc_pages_bulk(gfp, numa_mem_id(), NULL, nr_pages, list);

Discrepancy in the two return types here. Suspect they should both
be 'unsigned int' so there's no question about "can it return an errno".

>
> +/*

If you could make that "/**" instead ...