Re: [PATCH net-next v2] net: change netdev_unregister_timeout_secs min value to 1

Eric Dumazet
2021-03-25T16:08:22Z

On 3/25/21 3:52 PM, Dmitry Vyukov wrote:
> netdev_unregister_timeout_secs=0 can lead to printing the
> "waiting for dev to become free" message every jiffy.
> This is too frequent and unnecessary.
> Set the min value to 1 second.
>
> Also fix the merge issue introduced by
> "net: make unregister netdev warning timeout configurable":
> it changed "refcnt != 1" to "refcnt".
>
> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Fixes: 5aa3afe107d9 ("net: make unregister netdev warning timeout configurable")
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> Changes since v1:
> - fix merge issue related to refcnt check

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks !