Re: [PATCH v2 04/11] PCI: dwc: pcie-kirin: add support for Kirin 970 PCIe controller

kernel test robot
2021-02-03T09:34:26Z

[-- Attachment #1: Type: text/plain, Size: 3004 bytes --]

Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pci/next]
[also build test WARNING on linus/master v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Add-support-for-Hikey-970-PCIe/20210203-151220
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6c6f3407849b681518423b465433a46482b78ebc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Add-support-for-Hikey-970-PCIe/20210203-151220
git checkout 6c6f3407849b681518423b465433a46482b78ebc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/controller/dwc/pcie-kirin.c:238:6: warning: no previous prototype for 'kirin970_pcie_get_eyeparam' [-Wmissing-prototypes]
238 | void kirin970_pcie_get_eyeparam(struct kirin_pcie *pcie)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for FRAME_POINTER
Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
Selected by
- FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86

vim +/kirin970_pcie_get_eyeparam +238 drivers/pci/controller/dwc/pcie-kirin.c

237
> 238 void kirin970_pcie_get_eyeparam(struct kirin_pcie *pcie)
239 {
240 struct device *dev = pcie->pci->dev;
241 int i;
242 struct device_node *np;
243
244 np = dev->of_node;
245
246 if (of_property_read_u32_array(np, "eye_param", pcie->eye_param, 5)) {
247 for (i = 0; i < 5; i++)
248 pcie->eye_param[i] = EYEPARAM_NOCFG;
249 }
250
251 dev_dbg(dev, "eye_param_vboost = [0x%x]\n", pcie->eye_param[0]);
252 dev_dbg(dev, "eye_param_iboost = [0x%x]\n", pcie->eye_param[1]);
253 dev_dbg(dev, "eye_param_pre = [0x%x]\n", pcie->eye_param[2]);
254 dev_dbg(dev, "eye_param_post = [0x%x]\n", pcie->eye_param[3]);
255 dev_dbg(dev, "eye_param_main = [0x%x]\n", pcie->eye_param[4]);
256 }
257

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63467 bytes --]