* [PATCH] staging: rtl8723bs: fix indentation broken by previous patch [not found] <YFxQSJXXQ4dFPGS4@mwanda> @ 2021-03-25 9:56 ` Fabio Aiuto 2021-03-26 9:17 ` Fabio Aiuto 1 sibling, 0 replies; 8+ messages in thread From: Fabio Aiuto @ 2021-03-25 9:56 UTC (permalink / raw) To: dan.carpenter; +Cc: linux-staging, linux-kernel, Fabio Aiuto fix indentation broken by patch removing conditional code blocks checked by unused CONFIG_INTERRUPT_BASED_TXBCN family defines https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com> --- drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index 3cd9c61eec99..dc56477eb084 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -907,9 +907,9 @@ void start_bss_network(struct adapter *padapter, u8 *pbuf) if (pmlmeext->bstart_bss) { update_beacon(padapter, WLAN_EID_TIM, NULL, true); - /* issue beacon frame */ - if (send_beacon(padapter) == _FAIL) - DBG_871X("issue_beacon, fail!\n"); + /* issue beacon frame */ + if (send_beacon(padapter) == _FAIL) + DBG_871X("issue_beacon, fail!\n"); } -- 2.20.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] staging: rtl8723bs: fix indentation broken by previous patch [not found] <YFxQSJXXQ4dFPGS4@mwanda> 2021-03-25 9:56 ` [PATCH] staging: rtl8723bs: fix indentation broken by previous patch Fabio Aiuto @ 2021-03-26 9:17 ` Fabio Aiuto 2021-03-26 14:06 ` Greg KH 1 sibling, 1 reply; 8+ messages in thread From: Fabio Aiuto @ 2021-03-26 9:17 UTC (permalink / raw) To: gregkh; +Cc: dan.carpenter, linux-staging, linux-kernel, Fabio Aiuto fix indentation broken by patch removing conditional code blocks checked by unused CONFIG_INTERRUPT_BASED_TXBCN family defines https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com> --- drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index 3cd9c61eec99..dc56477eb084 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -907,9 +907,9 @@ void start_bss_network(struct adapter *padapter, u8 *pbuf) if (pmlmeext->bstart_bss) { update_beacon(padapter, WLAN_EID_TIM, NULL, true); - /* issue beacon frame */ - if (send_beacon(padapter) == _FAIL) - DBG_871X("issue_beacon, fail!\n"); + /* issue beacon frame */ + if (send_beacon(padapter) == _FAIL) + DBG_871X("issue_beacon, fail!\n"); } -- 2.20.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: rtl8723bs: fix indentation broken by previous patch 2021-03-26 9:17 ` Fabio Aiuto @ 2021-03-26 14:06 ` Greg KH 2021-03-26 15:52 ` [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) Fabio Aiuto 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2021-03-26 14:06 UTC (permalink / raw) To: Fabio Aiuto; +Cc: dan.carpenter, linux-staging, linux-kernel On Fri, Mar 26, 2021 at 10:17:16AM +0100, Fabio Aiuto wrote: > fix indentation broken by patch removing conditional > code blocks checked by unused > CONFIG_INTERRUPT_BASED_TXBCN family defines > > https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com > > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com> "previous patch" is not very descriptive :( Please put a "Fixes:" tag in here to point out exactly what commit this fixed, and maybe a "Reported-by:" tag if someone pointed this out to you... thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) 2021-03-26 14:06 ` Greg KH @ 2021-03-26 15:52 ` Fabio Aiuto 2021-03-26 16:20 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Fabio Aiuto @ 2021-03-26 15:52 UTC (permalink / raw) To: gregkh; +Cc: dan.carpenter, linux-staging, linux-kernel, Fabio Aiuto fix indentation broken by patch removing conditional code blocks checked by unused CONFIG_INTERRUPT_BASED_TXBCN family defines https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com> --- drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index 3cd9c61eec99..dc56477eb084 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -907,9 +907,9 @@ void start_bss_network(struct adapter *padapter, u8 *pbuf) if (pmlmeext->bstart_bss) { update_beacon(padapter, WLAN_EID_TIM, NULL, true); - /* issue beacon frame */ - if (send_beacon(padapter) == _FAIL) - DBG_871X("issue_beacon, fail!\n"); + /* issue beacon frame */ + if (send_beacon(padapter) == _FAIL) + DBG_871X("issue_beacon, fail!\n"); } -- 2.20.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) 2021-03-26 15:52 ` [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) Fabio Aiuto @ 2021-03-26 16:20 ` Greg KH 2021-03-26 17:43 ` Fabio Aiuto 2021-03-26 18:06 ` [PATCH] staging: rtl8723bs: fix broken indentation Fabio Aiuto 0 siblings, 2 replies; 8+ messages in thread From: Greg KH @ 2021-03-26 16:20 UTC (permalink / raw) To: Fabio Aiuto; +Cc: dan.carpenter, linux-staging, linux-kernel On Fri, Mar 26, 2021 at 04:52:52PM +0100, Fabio Aiuto wrote: > fix indentation broken by patch removing conditional > code blocks checked by unused > CONFIG_INTERRUPT_BASED_TXBCN family defines > > https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com No, please use a "Fixes:" tag that points to the git commit id that this commit fixes. Look in the kernel tree for loads of examples of how to do this, and it's even documented in the Documentation/ process guide as well. thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) 2021-03-26 16:20 ` Greg KH @ 2021-03-26 17:43 ` Fabio Aiuto 2021-03-26 17:57 ` Fabio Aiuto 2021-03-26 18:06 ` [PATCH] staging: rtl8723bs: fix broken indentation Fabio Aiuto 1 sibling, 1 reply; 8+ messages in thread From: Fabio Aiuto @ 2021-03-26 17:43 UTC (permalink / raw) To: Greg KH; +Cc: dan.carpenter, linux-staging, linux-kernel On Fri, Mar 26, 2021 at 05:20:40PM +0100, Greg KH wrote: > On Fri, Mar 26, 2021 at 04:52:52PM +0100, Fabio Aiuto wrote: > > fix indentation broken by patch removing conditional > > code blocks checked by unused > > CONFIG_INTERRUPT_BASED_TXBCN family defines > > > > https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com > > No, please use a "Fixes:" tag that points to the git commit id that this > commit fixes. Look in the kernel tree for loads of examples of how to > do this, and it's even documented in the Documentation/ process guide as > well. > > thanks, > > greg k-h is what I did, as you can see in the subject. Or I did wrong? thank you, fabio ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) 2021-03-26 17:43 ` Fabio Aiuto @ 2021-03-26 17:57 ` Fabio Aiuto 0 siblings, 0 replies; 8+ messages in thread From: Fabio Aiuto @ 2021-03-26 17:57 UTC (permalink / raw) To: Greg KH; +Cc: dan.carpenter, linux-staging, linux-kernel On Fri, Mar 26, 2021 at 06:43:28PM +0100, Fabio Aiuto wrote: > On Fri, Mar 26, 2021 at 05:20:40PM +0100, Greg KH wrote: > > On Fri, Mar 26, 2021 at 04:52:52PM +0100, Fabio Aiuto wrote: > > > fix indentation broken by patch removing conditional > > > code blocks checked by unused > > > CONFIG_INTERRUPT_BASED_TXBCN family defines > > > > > > https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com > > > > No, please use a "Fixes:" tag that points to the git commit id that this > > commit fixes. Look in the kernel tree for loads of examples of how to > > do this, and it's even documented in the Documentation/ process guide as > > well. > > > > thanks, > > > > greg k-h > > is what I did, as you can see in the subject. Or I did wrong? > > thank you, > > fabio forget this message :( I will send you the patch correctly formatted, just seen some examples. I thought the 'Fixes: ...' was the one line desc. thank you fabio ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] staging: rtl8723bs: fix broken indentation 2021-03-26 16:20 ` Greg KH 2021-03-26 17:43 ` Fabio Aiuto @ 2021-03-26 18:06 ` Fabio Aiuto 1 sibling, 0 replies; 8+ messages in thread From: Fabio Aiuto @ 2021-03-26 18:06 UTC (permalink / raw) To: gregkh; +Cc: dan.carpenter, linux-staging, linux-kernel, Fabio Aiuto fix indentation broken by patch removing conditional code blocks checked by unused CONFIG_INTERRUPT_BASED_TXBCN family defines Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com> --- drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c index 3cd9c61eec99..dc56477eb084 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -907,9 +907,9 @@ void start_bss_network(struct adapter *padapter, u8 *pbuf) if (pmlmeext->bstart_bss) { update_beacon(padapter, WLAN_EID_TIM, NULL, true); - /* issue beacon frame */ - if (send_beacon(padapter) == _FAIL) - DBG_871X("issue_beacon, fail!\n"); + /* issue beacon frame */ + if (send_beacon(padapter) == _FAIL) + DBG_871X("issue_beacon, fail!\n"); } -- 2.20.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-03-26 18:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <YFxQSJXXQ4dFPGS4@mwanda>
2021-03-25 9:56 ` [PATCH] staging: rtl8723bs: fix indentation broken by previous patch Fabio Aiuto
2021-03-26 9:17 ` Fabio Aiuto
2021-03-26 14:06 ` Greg KH
2021-03-26 15:52 ` [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) Fabio Aiuto
2021-03-26 16:20 ` Greg KH
2021-03-26 17:43 ` Fabio Aiuto
2021-03-26 17:57 ` Fabio Aiuto
2021-03-26 18:06 ` [PATCH] staging: rtl8723bs: fix broken indentation Fabio Aiuto
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox